Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to embedded-hal:1.0.0-alpha.10 #66

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

rursprung
Copy link
Contributor

note that i updated this purely based on the build errors and the release notes.

note that i updated this purely based on the build errors and the
[release notes].

[release notes]: https://github.com/rust-embedded/embedded-hal/releases/tag/v1.0.0-alpha.10
@rursprung
Copy link
Contributor Author

@Dirbaio and @eldruin: nearly all commits in e-h 1.0.0-alpha.10 come from you. could you please double-check if the changes here match the expectations you have for the implementation of these APIs? thanks!

this is a preparation to later add the mock implementation of the new e-h 1.0 PWM APIs (which are new with this release, so the update is a pre-requisite).

Copy link
Collaborator

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to do this myself, glad I checked for open PRs first!

Looks good to me!

@dbrgn
Copy link
Owner

dbrgn commented Apr 15, 2023

Great, thanks @rursprung @newAM!

@dbrgn dbrgn merged commit e55ac12 into dbrgn:1-alpha Apr 15, 2023
@rursprung rursprung deleted the update-to-1.0.0-alpha.10 branch April 17, 2023 08:33
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, thanks!

tommy-gilligan pushed a commit to tommy-gilligan/embedded-hal-mock that referenced this pull request Jul 5, 2023
note that i updated this purely based on the build errors and the
[release notes].

[release notes]: https://github.com/rust-embedded/embedded-hal/releases/tag/v1.0.0-alpha.10
tommy-gilligan pushed a commit to tommy-gilligan/embedded-hal-mock that referenced this pull request Jul 5, 2023
note that i updated this purely based on the build errors and the
[release notes].

[release notes]: https://github.com/rust-embedded/embedded-hal/releases/tag/v1.0.0-alpha.10
tommy-gilligan pushed a commit to tommy-gilligan/embedded-hal-mock that referenced this pull request Jul 5, 2023
note that i updated this purely based on the build errors and the
[release notes].

[release notes]: https://github.com/rust-embedded/embedded-hal/releases/tag/v1.0.0-alpha.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants