Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Circled Image not visible on B&W E-Ink screen #339

Conversation

nthState
Copy link
Contributor

@nthState nthState commented Jan 3, 2023

fix: Circled Image not visible on B&W E-Ink screen

Background

I've been reading this book on my Kindle, which has a black and white e-ink screen, when I came to the section about a pin header, I couldn't easily see the circled pin header.

Fix

The fix was to change the way the image was highlighted

Old (Colour) Old (Black and White)
verify verify_bw
New (Colour) New (Black and White)
verify_new verify_bw_new

Testing Steps

  • Use a device with a black & white screen, preferably an e-ink screen and view the intro/install section of the book

Acceptance Criteria

  • The image looks good in both colour and black and white
  • The image has an acceptable highlight in both colour and black and white

@nthState nthState changed the title fix: Circled pin header image changed to be better viewed on a b&w e-… fix: Circled Image not visible on B&W E-Ink screen Jan 3, 2023
@nthState nthState marked this pull request as ready for review January 3, 2023 12:08
@nthState nthState requested a review from a team as a code owner January 3, 2023 12:08
@adamgreig
Copy link
Member

Thanks, this is a good improvement! I wonder if it could be even higher contrast when in colour though -- perhaps the rest of the image could be even further dimmed, or a thick border in another colour added around the highlight region?

@jonathanpallant
Copy link

I'd merge this as-is; it's a good enough improvement and we can always go around again later.

@nthState
Copy link
Contributor Author

Apologies, I'm not a great user of graphical tools to create what you suggest/need

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this got dropped, thanks for the improvement!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 31, 2023

Build succeeded:

@bors bors bot merged commit 701d155 into rust-embedded:master Jan 31, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 13, 2023
Update books

## rust-lang/book

2 commits in f2a78f64b668f63f581203c6bac509903f7c00ee..d94e03a18a2590ed3f1c67b859cb11528d2a2d5c
2023-02-10 16:01:09 UTC to 2023-02-10 15:55:43 UTC

- Update to Rust 1.67.1
- Update to Rust 1.66.1

## rust-embedded/book

1 commits in f1a4614aa41cc544b91b79760a709e113f3451d7..701d1551429da4cb609082c0ac99df569e336710
2023-01-31 12:32:49 UTC to 2023-01-31 12:32:49 UTC

- fix: Circled Image not visible on B&W E-Ink screen (rust-embedded/book#339)

## rust-lang/nomicon

2 commits in bd1829d235296952bf72ca55635e360584b8805e..79b53665a7c61d171fb8c5ad0b73b371f9ee6ba7
2023-02-13 08:40:24 UTC to 2023-02-07 09:43:03 UTC

- Fixes double bug in Send-Sync example (rust-lang/nomicon#401)
- Small language fix in subtyping.md (rust-lang/nomicon#399)

## rust-lang/reference

4 commits in 22882fb3f7b4d69fdc0d1731e8b9cfcb6910537d..e5adb99c04817b7fbe08f4ffce5b36702667345f
2023-02-08 18:09:03 UTC to 2023-02-01 03:49:46 UTC

- Eliminate 'half open' terminology from range pattern grammar (rust-lang/reference#1330)
- fix place expression context example (rust-lang/reference#1327)
- remove confusing words (rust-lang/reference#1324)
- Reword "expression for a match arm" (rust-lang/reference#1325)

## rust-lang/rust-by-example

5 commits in 134376872e8c387ef369507e0ee9b5a0e3272718..efe23c4fe12e06351b8dc8c3d18312c761455109
2023-02-06 11:32:23 UTC to 2023-01-31 16:38:03 UTC

- fix irrelevant comments (rust-lang/rust-by-example#1676)
- remove redudant code (rust-lang/rust-by-example#1675)
- Line comments: change 'inside' to 'after' (rust-lang/rust-by-example#1674)
- fix incorrect trait bound demonstration (rust-lang/rust-by-example#1673)
- fix "High Order Functions" typo (rust-lang/rust-by-example#1672)

## rust-lang/rustc-dev-guide

14 commits in e359ee2..41a96ab
2023-02-11 06:41:56 UTC to 2023-01-31 18:42:30 UTC

- Add a citation file (rust-lang/rustc-dev-guide#1550)
- Improve git submodule help (rust-lang/rustc-dev-guide#1587)
- update examples for rustc 1.69.0-nightly (e1eaa2d 2023-02-06) (rust-lang/rustc-dev-guide#1590)
- Replace settings.json with x.py setup note (rust-lang/rustc-dev-guide#1588)
- Do not add accept header on linkcheck (rust-lang/rustc-dev-guide#1586)
- Fixed small grammar mistake in monomorph.md (rust-lang/rustc-dev-guide#1585)
- update bootstrap guide (rust-lang/rustc-dev-guide#1583)
- Use host symlink for custom rustup toolchain (rust-lang/rustc-dev-guide#1580)
- Fix broken links (rust-lang/rustc-dev-guide#1577)
- Add section on comparing types (rust-lang/rustc-dev-guide#1570)
- Update rustfmt path (rust-lang/rustc-dev-guide#1574)
- fix wrong heading level (rust-lang/rustc-dev-guide#1573)
- fix incorrect position of `Clarification of build command's stdout` (rust-lang/rustc-dev-guide#1572)
- extend bootstrap related documentations (rust-lang/rustc-dev-guide#1563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants