Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #1577

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Fix broken links #1577

merged 6 commits into from
Feb 3, 2023

Conversation

JohnTitor
Copy link
Member

I'd recommend reviewing commit by commit.

Signed-off-by: Yuki Okushi jtitor@2k36.org

@JohnTitor
Update explnation about benchmarks
bbac848 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Address the change in rust-lang/rust#107256
55d62d1 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Address the change in rust-lang/rust#97287
94774b4 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Address the change in rust-lang/rust#106718
57ed4e7 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Address the change in rust-lang/rust#99715
77038f6 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Fix broken relative links
97cc2d0 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
tshepang
tshepang reviewed Feb 2, 2023
View reviewed changes
src/mir/visitor.md
Comment on lines -40 to +43
A very simple example of a visitor can be found in [`LocalUseCounter`].
By implementing `visit_local` method, this visitor counts how many times each local is used.
A very simple example of a visitor can be found in [`LocalUseVisitor`].
By implementing `visit_local` method, this visitor counts how many times each local is mutably used.

[`LocalUseCounter`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/simplify_try/struct.LocalUseCounter.html
[`LocalUseVisitor`]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir_transform/const_debuginfo/struct.LocalUseVisitor.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the choice of this over the other type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See rust-lang/rust#107256, which is mentioned in the commit message of this change, the struct was removed to simplify, we have to find another example to show how visit_local is used.

@tshepang
Copy link
Member

tshepang commented Feb 2, 2023 •
edited
Loading

just one question, otherwise looks all good

sidenote: would it be alright to split these kinds into separate PRs in future, for it can take a while to review the whole thing at once

@lukas-code lukas-code mentioned this pull request Feb 2, 2023
Closed
@JohnTitor
Copy link
Member Author

JohnTitor commented Feb 2, 2023 •
edited
Loading

sidenote: would it be alright to split these kinds into separate PRs in future, for it can take a while to review the whole thing at once

To make reviews easier, I've split the commits with the culprit PRs' links, and there are only 6 commits with 10 or so diff lines. I don't think it's supposed to take hours to review. This also doesn't contain any major changes that require expert's review, I think.

@tshepang tshepang merged commit d579acb into rust-lang:master Feb 3, 2023
@JohnTitor JohnTitor deleted the fix-links-feb-2023 branch February 3, 2023 05:14
@tshepang
Copy link
Member

tshepang commented Feb 3, 2023

I was reviewing commit-by-commit (as suggested), but only realized later that links are added to the commit messages... such are rather easy to miss with GitHub UI. Thanks for making it easy.

@JohnTitor
Copy link
Member Author

I see, I'm going to mention it on OP explicitly next time then! I'd like to try splitting if the context is complex and needs some time/eyes to review 👍

@rustbot rustbot mentioned this pull request Feb 13, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 13, 2023
@matthiaskrgr
Rollup merge of rust-lang#108002 - rustbot:docs-update, r=ehuss
9bf807e 
Update books

## rust-lang/book

2 commits in f2a78f64b668f63f581203c6bac509903f7c00ee..d94e03a18a2590ed3f1c67b859cb11528d2a2d5c
2023-02-10 16:01:09 UTC to 2023-02-10 15:55:43 UTC

- Update to Rust 1.67.1
- Update to Rust 1.66.1

## rust-embedded/book

1 commits in f1a4614aa41cc544b91b79760a709e113f3451d7..701d1551429da4cb609082c0ac99df569e336710
2023-01-31 12:32:49 UTC to 2023-01-31 12:32:49 UTC

- fix: Circled Image not visible on B&W E-Ink screen (rust-embedded/book#339)

## rust-lang/nomicon

2 commits in bd1829d235296952bf72ca55635e360584b8805e..79b53665a7c61d171fb8c5ad0b73b371f9ee6ba7
2023-02-13 08:40:24 UTC to 2023-02-07 09:43:03 UTC

- Fixes double bug in Send-Sync example (rust-lang/nomicon#401)
- Small language fix in subtyping.md (rust-lang/nomicon#399)

## rust-lang/reference

4 commits in 22882fb3f7b4d69fdc0d1731e8b9cfcb6910537d..e5adb99c04817b7fbe08f4ffce5b36702667345f
2023-02-08 18:09:03 UTC to 2023-02-01 03:49:46 UTC

- Eliminate 'half open' terminology from range pattern grammar (rust-lang/reference#1330)
- fix place expression context example (rust-lang/reference#1327)
- remove confusing words (rust-lang/reference#1324)
- Reword "expression for a match arm" (rust-lang/reference#1325)

## rust-lang/rust-by-example

5 commits in 134376872e8c387ef369507e0ee9b5a0e3272718..efe23c4fe12e06351b8dc8c3d18312c761455109
2023-02-06 11:32:23 UTC to 2023-01-31 16:38:03 UTC

- fix irrelevant comments (rust-lang/rust-by-example#1676)
- remove redudant code (rust-lang/rust-by-example#1675)
- Line comments: change 'inside' to 'after' (rust-lang/rust-by-example#1674)
- fix incorrect trait bound demonstration (rust-lang/rust-by-example#1673)
- fix "High Order Functions" typo (rust-lang/rust-by-example#1672)

## rust-lang/rustc-dev-guide

14 commits in e359ee2..41a96ab
2023-02-11 06:41:56 UTC to 2023-01-31 18:42:30 UTC

- Add a citation file (rust-lang/rustc-dev-guide#1550)
- Improve git submodule help (rust-lang/rustc-dev-guide#1587)
- update examples for rustc 1.69.0-nightly (e1eaa2d 2023-02-06) (rust-lang/rustc-dev-guide#1590)
- Replace settings.json with x.py setup note (rust-lang/rustc-dev-guide#1588)
- Do not add accept header on linkcheck (rust-lang/rustc-dev-guide#1586)
- Fixed small grammar mistake in monomorph.md (rust-lang/rustc-dev-guide#1585)
- update bootstrap guide (rust-lang/rustc-dev-guide#1583)
- Use host symlink for custom rustup toolchain (rust-lang/rustc-dev-guide#1580)
- Fix broken links (rust-lang/rustc-dev-guide#1577)
- Add section on comparing types (rust-lang/rustc-dev-guide#1570)
- Update rustfmt path (rust-lang/rustc-dev-guide#1574)
- fix wrong heading level (rust-lang/rustc-dev-guide#1573)
- fix incorrect position of `Clarification of build command's stdout` (rust-lang/rustc-dev-guide#1572)
- extend bootstrap related documentations (rust-lang/rustc-dev-guide#1563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshepang tshepang tshepang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnTitor @tshepang