Add thumbv8m main. #167
Add thumbv8m main. #167
Conversation
|
The Travis build is failing because it relies on cortex-m supporting thumbv8m.main already - after the PR in cortex-m is integrated it should work. |
130: Add thumbv8m main. r=adamgreig a=nezza rustup supports the `thumbv8m.main-none-eabi` target, this adds support for `thumbv8m.main-none-eabi` to cortex-m. Related PRs: rust-embedded/cortex-m-semihosting#28 rust-embedded/cortex-m-rt#167 Co-authored-by: Thomas Roth <thomas.roth@leveldown.de>
|
bors try |
tryBuild failed |
|
@adamgreig mentioned we have to wait for a new release, cause the cortex-m module is version fixed |
|
Can I do anything to push this along? I have an M33 and I want to try it out! |
|
bors try |
tryBuild failed |
|
Ping from triage: @nezza will resolving iusee rust-embedded/cortex-m#131 make bors happy ? |
|
My understanding is that a cortex-m (minor) release would make bors happy (someone in IRC said so at least :) ) |
28: Add thumbv8m main. r=adamgreig a=nezza rustup supports the `thumbv8m.main-none-eabi` target, this adds support for `thumbv8m.main-none-eabi` to cortex-m-semihosting. Related PRs: rust-embedded/cortex-m#130 rust-embedded/cortex-m-rt#167 Co-authored-by: Thomas Roth <thomas.roth@leveldown.de>
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make nezza a reviewer |
|
bors try |
tryBuild failed |
|
thumv8m support requires cortex-m 0.6+ I believe. Also it seems the assembler files don't match. |
|
Yep, I'll push an increase to 0.6.0 in a bit |
|
You may also need a newer GCC. I'm having trouble with the arm-none-eabi-gcc included with Ubuntu 18.04. The latest pre-built GCC from ARM (gcc-arm-none-eabi-8-2018-q4-major) works fine. |
|
Thanks for the hint, will take a look! |
|
The build is already using cortex-m 0.6 (since I updated Cargo.toml to use >0.5.7 <0.7), but it's also using cortex-m 0.5.7 for something else I suppose. Anyway the failure in this case seems to be the assembler files. You can see it's using cortex-m 0.6 here: https://travis-ci.org/rust-embedded/cortex-m-rt/jobs/506709530 |
|
https://crates.io/crates/cortex-m-semihosting hasn't been updated, so that's pulling in cortex-m 0.5.x. Not sure why this crate depends on -semihosting. |
|
@rust-embedded/cortex-m seems that we have 2 PR for the same feature ? #182 |
|
@thejpster looks like it is in example/qemu.rs |
Mine also adds the missing cfg flags. You can do this one then mine, or just mine. |
|
Merged #182 and I think this one should not be needed, if I missed something reopen this. |
rustup supports the
thumbv8m.main-none-eabitarget, this adds support forthumbv8m.main-none-eabito cortex-m-rt.Related PRs:
rust-embedded/cortex-m-semihosting#28
rust-embedded/cortex-m#130