Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Add thumbv8m.main support. #182

Merged
merged 5 commits into from
Mar 18, 2019
Merged

Add thumbv8m.main support. #182

merged 5 commits into from
Mar 18, 2019

Conversation

thejpster
Copy link
Contributor

  • Add thumbv8m.main support.
  • Also adds feature flags into build.rs so SecureFault gets included.

@thejpster
Add thumbv8m.main support.
002dce0 
Add feature flags into build.rs so SecureFault gets included.
@thejpster thejpster requested a review from a team as a code owner March 12, 2019 19:56
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@thejpster thejpster mentioned this pull request Mar 12, 2019
Closed
@thejpster
Copy link
Contributor Author

Ok, so there are two issues:

  1. There's some overlap with Add thumbv8m main. #167. That's fine, I can re-base.
  2. I have no idea how many Interrupt Vectors to set as the maximum when building for a non-Cortex-M target (which we do why?)

@therealprof
Copy link
Contributor

@thejpster previously we just used the same number as for non-armv6m. But the explicit panic! also doesn't help a bit... ;)

@adamgreig
Copy link
Member

Hopefully this (or #167, however that works out) can be merged once #183 is done.

@adamgreig
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 15, 2019
@bors
Try #182:
db0172c
@bors
Copy link
Contributor

bors bot commented Mar 15, 2019

try

Build failed

@adamgreig
Copy link
Member

@thejpster looks like you have some more-useful errors to investigate now ;)

@mathk mathk mentioned this pull request Mar 15, 2019
Closed
@thejpster thejpster mentioned this pull request Mar 17, 2019
Closed
@hug-dev hug-dev mentioned this pull request Mar 17, 2019
Closed
@thejpster
Copy link
Contributor Author

Builds are now green.

korken89
korken89 approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great work! LGTM

@korken89
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Mar 18, 2019
@bors @thejpster
Merge #182
1cd2044 
182: Add thumbv8m.main support. r=korken89 a=thejpster

* Add thumbv8m.main support.
* Also adds feature flags into build.rs so SecureFault gets included.

Co-authored-by: Jonathan 'theJPster' Pallant <github@thejpster.org.uk>
@bors
Copy link
Contributor

bors bot commented Mar 18, 2019

Build succeeded

@bors bors bot merged commit 5027cea into rust-embedded:master Mar 18, 2019
@thejpster thejpster deleted the fix_cfg_flags branch March 18, 2019 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@korken89 korken89 korken89 approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thejpster @rust-highfive @therealprof @adamgreig @korken89