Skip to content

Commit

Permalink
Merge #354
Browse files Browse the repository at this point in the history
354: Remove Qei trait as it has an unconstrained associated type r=ryankurte a=eldruin

For now. See #324 for the reasoning.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
  • Loading branch information
bors[bot] and eldruin authored Feb 10, 2022
2 parents 2f5d994 + 5482348 commit 807172a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 83 deletions.
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,23 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- `i2c`: traits now enforce all impls on the same struct have the same `Error` type.
- `i2c`: unify all traits into a single `I2c` trait.

### Removed
- Traits with unconstrained associated types and their modules (See: [#324], [#354]):
- `capture::Capture`
- `pwm::Pwm`
- `pwm::PwmPin`
- `qei::Qei`
- `timer::Cancel`
- `timer::CountDown`
- `timer::Periodic`
- `watchdog::Disable`
- `watchdog::Enable`
- `watchdog::Watchdog`


[#324]: https://github.com/rust-embedded/embedded-hal/pull/324/
[#354]: https://github.com/rust-embedded/embedded-hal/pull/354

## [v1.0.0-alpha.6] - 2021-11-19

*** This is (also) an alpha release with breaking changes (sorry) ***
Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@ pub mod can;
pub mod delay;
pub mod digital;
pub mod i2c;
pub mod qei;
pub mod serial;
pub mod spi;

Expand Down
82 changes: 0 additions & 82 deletions src/qei.rs

This file was deleted.

0 comments on commit 807172a

Please sign in to comment.