Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Qei trait as it has an unconstrained associated type #354

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Remove Qei trait as it has an unconstrained associated type #354

merged 2 commits into from
Feb 10, 2022

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Feb 9, 2022 •
edited
Loading

For now. See #324 for the reasoning and #362 if you are interested in adding this trait back.

@eldruin eldruin requested a review from a team as a code owner February 9, 2022 20:58
@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Feb 9, 2022
Dirbaio
Dirbaio approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👍

@eldruin eldruin mentioned this pull request Feb 9, 2022
Merged
ryankurte
ryankurte approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 10, 2022

Build succeeded:

@bors bors bot merged commit 807172a into rust-embedded:master Feb 10, 2022
bors bot added a commit that referenced this pull request Feb 10, 2022
@bors @eldruin
Merge #355
173750c 
355: Prepare 1.0.0-alpha.7 release r=ryankurte a=eldruin

#354 should be merged/rejected beforehand

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@eldruin eldruin deleted the remove-qei branch February 10, 2022 07:16
@eldruin
Copy link
Member Author

eldruin commented Feb 13, 2022

If you are interested in bringing this trait back, please participate in #362

@jannic jannic mentioned this pull request Feb 22, 2022
Merged
@eldruin eldruin added this to the v1.0.0 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

@ryankurte ryankurte ryankurte approved these changes

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eldruin @rust-highfive @ryankurte @Dirbaio