Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from travis to Github Actions and setup bors #23

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

therealprof
Copy link
Contributor

Signed-off-by: Daniel Egger daniel@eggers-club.de

@eldruin
Copy link
Member

eldruin commented Jun 27, 2020

I think this should only build on stable but not attempt to run the tests since they need nightly.

@therealprof
Copy link
Contributor Author

Yeah, need to make the tests conditional somehow. This is clearly less than ideal to have CI depend on a nightly version.

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof
Copy link
Contributor Author

@ryankurte @ithinuel Can I get an approval here?

@eldruin
Copy link
Member

eldruin commented Jun 27, 2020

Yes. One thing that bugs me specially is that await! includes yield in its expansion and I am not sure what kind of error you would get if attempting to use it on Rust stable. Probably something pretty weird.
I will have a look at adding a build.rs to only include it on nightly.

@therealprof
Copy link
Contributor Author

@eldruin You should be able to approve this now. Want to give it a try? ;)

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@eldruin eldruin merged commit 167480f into master Jun 29, 2020
@bors bors bot deleted the move-to-gha branch June 29, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants