Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship a 1.0 release #20

Closed
10 tasks done
thejpster opened this issue Jan 9, 2020 · 4 comments
Closed
10 tasks done

Ship a 1.0 release #20

thejpster opened this issue Jan 9, 2020 · 4 comments

Comments

@thejpster
Copy link

thejpster commented Jan 9, 2020

Part of rust-embedded/wg#383

Add blocking issues here:

@hannobraun
Copy link
Member

I guess the main blocking issue would be, whether this crate offers the right approach at all, and whether/how it needs to change (or be discarded completely) in the face of the async stuff that already landed in Rust, and is yet to come. See #14, rust-embedded/embedded-hal#149, and rust-embedded/embedded-hal#172.

@eldruin
Copy link
Member

eldruin commented Mar 15, 2020

I would nominate #22 for this.

@eldruin
Copy link
Member

eldruin commented Jun 24, 2020

Further TODOs:

@jonas-schievink
Copy link

  • Remove unstable feature
  • Only include await! in Rust nightly via build.rs?

I prefer the current approach of having to opt into unstable features. It mirrors how unstable features in Rust work, and if we automatically enable unstable feature for nightly Rust versions people could accidentally start using an unstable feature in this library just because their installation happens to default to the nightly Rust channel (which is a reasonable thing to do in order to use unstable compiler flags and benefit from recent performance improvements, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants