Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unstable feature and code and modernize #32

Merged
merged 5 commits into from
Jul 3, 2020
Merged

Remove unstable feature and code and modernize #32

merged 5 commits into from
Jul 3, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jul 2, 2020

The tests can now be run on Rust >= 1.34.0 (due to Infallible).
Closes #28

@eldruin
Copy link
Member Author

eldruin commented Jul 2, 2020

Can I get a review here @rust-embedded/hal ?
BTW I discovered that the commit of the 0.1.2 release was not merged into master. I have done that here as well.

@therealprof
Copy link
Contributor

@eldruin As mentioned here: #28 (comment) we said we would wait a few days for objections before executing.

therealprof
therealprof reviewed Jul 2, 2020
View reviewed changes
src/lib.rs Show resolved Hide resolved
therealprof
therealprof requested changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one Infallible nit LGTM.

@eldruin
Copy link
Member Author

eldruin commented Jul 2, 2020

Great. Should be solved now.

@therealprof
Copy link
Contributor

Would you like to keep the 11 commits or condense this a bit more? (No request, just a question)

I think we'll wait until tomorrow and then I'll pull the trigger.

@eldruin
Copy link
Member Author

eldruin commented Jul 2, 2020

Hmm I could squash them but then we would lose the info about the merged 0.1.2 release commit, since I discovered that too late.
I could squash around that in a new branch with cherry picking and so on but honestly it feels like busy work.

@therealprof
Copy link
Contributor

@eldruin Hah, you could use that opportunity to learn about git rebase -i. ;)

@eldruin eldruin force-pushed the remove-unstable-and-modernize branch from f03493e to 885f461 Compare July 3, 2020 06:53
@eldruin
Copy link
Member Author

eldruin commented Jul 3, 2020

Ok I've squashed them now.

therealprof
therealprof reviewed Jul 3, 2020
View reviewed changes
Cargo.toml Show resolved Hide resolved
@eldruin eldruin force-pushed the remove-unstable-and-modernize branch 2 times, most recently from 885f461 to d876154 Compare July 3, 2020 12:05
@eldruin eldruin force-pushed the remove-unstable-and-modernize branch from d876154 to 4cb937c Compare July 3, 2020 12:06
therealprof
therealprof approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 3, 2020

Build succeeded:

@bors bors bot merged commit 0d8d936 into rust-embedded:master Jul 3, 2020
@eldruin eldruin deleted the remove-unstable-and-modernize branch July 3, 2020 12:16
@thejpster thejpster mentioned this pull request Jul 3, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldruin @therealprof @japaric