Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document current MSRV #30

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Document current MSRV #30

merged 1 commit into from
Jul 4, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jun 30, 2020

This documents the MSRV used in CI, however, this crate builds with a much older Rust version.
Would there be interest in lowering it?

@therealprof
Copy link
Contributor

Well, the MSRV is not too useful as long as we support "unstable". Depending on consensus whether we would like to remove the unstable bits I'd be fine with 1.35.

@thejpster thejpster mentioned this pull request Jul 3, 2020
Closed
10 tasks
@eldruin
Copy link
Member Author

eldruin commented Jul 3, 2020

Ok, now that unstable is out: I think 1.35 MSRV should be fine.
Nobody has commented here saying that they would need an older version and anyway further lowering it if somebody really really needs it is non-breaking so we are good.

For the record, the tests run with Rust >= 1.34 due to Infallible and the code itself builds fine with a much older Rust version.

@eldruin eldruin mentioned this pull request Jul 3, 2020
Merged
therealprof
therealprof approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 4, 2020

Build succeeded:

@bors bors bot merged commit 8b497f0 into rust-embedded:master Jul 4, 2020
@eldruin eldruin deleted the document-msrv branch July 4, 2020 05:24
bors bot added a commit that referenced this pull request Jul 7, 2020
@bors @eldruin
Merge #33
075ecd3 
33: Prepare 1.0.0 r=therealprof a=eldruin

Release depends on #30 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eldruin @therealprof