Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional fields in Device when non strict, svd-parser 0.13.1 #193

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jan 4, 2022

No description provided.

@burrbull burrbull requested a review from a team as a code owner January 4, 2022 17:19
@adamgreig
Copy link
Member

Will strict mode still check these exist?

@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2022

Yes.

svd/svd-rs/src/device.rs

Lines 248 to 257 in 23c628f

version: self
.version
.or_else(|| {
if !lvl.is_strict() {
Some("1.0".into())
} else {
None
}
})
.ok_or_else(|| BuildError::Uninitialized("version".to_string()))?,

@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2022

Wait for check in rust-embedded/svd2rust#556

@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2022

Made typo. Sorry

Co-authored-by: Adam Greig <adam@adamgreig.com>
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

Build succeeded:

@bors bors bot merged commit 6937195 into master Jan 4, 2022
@bors bors bot deleted the version branch January 4, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants