serde YAML/JSON input #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @adamgreig (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
Emilgardis
reviewed
Dec 10, 2021
src/util.rs
Outdated
| @@ -73,6 +73,20 @@ impl Default for Target { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(unused)] | |||
There was a problem hiding this comment.
Why allow unused? Should this not be defined in main.rs maybe?
src/lib.rs
Outdated
Comment on lines
535
to
542
| let mut parser_config = svd_parser::Config::default(); | ||
| parser_config.validate_level = if config.strict { | ||
| svd::ValidateLevel::Strict | ||
| } else { | ||
| svd::ValidateLevel::Weak | ||
| }; | ||
|
|
||
| let device = svd_parser::parse_with_config(xml, &parser_config)?; |
There was a problem hiding this comment.
oops :D
this should probably be mentioned in the changelog.
Correctly use config when using
svd2rust::generateas a library
burrbull
force-pushed
the
serde-parse
branch
2 times, most recently
from
f802fd5 to
995708b
Compare
|
Should be fixed |
Emilgardis
reviewed
Dec 10, 2021
burrbull
force-pushed
the
serde-parse
branch
2 times, most recently
from
350edd5 to
72f5745
Compare
|
Rebased |
|
How would one use this? Are there parsable examples we could/should include? |
|
Espressif test was disabled. See esp-rs/xtensa-lx#14 |
burrbull
force-pushed
the
serde-parse
branch
3 times, most recently
from
4c25ef2 to
9b2a6e8
Compare
|
For testing with CI. New |
burrbull
force-pushed
the
serde-parse
branch
3 times, most recently
from
83bcf59 to
a443218
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.