Skip to content

Media formatting #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngelOnFira opened this issue Mar 2, 2020 · 4 comments · Fixed by #77 or #86
Closed

Media formatting #76

AngelOnFira opened this issue Mar 2, 2020 · 4 comments · Fixed by #77 or #86

Comments

@AngelOnFira
Copy link
Member

While trying to make a better way to show youtube videos, there was a discussion in #71. It was discussed that it is ideal to stay purely with markdown so that we can see what files look like directly from Github.

It would be nice to have content such as images and gifs be displayed in a bit of a cleaner way in the end product. A big one is centering images, as well as spacing around content. I think this can be done purely through CSS. I think it will really make the newsletter more presentable. I would love to hear other opinions!

image

@17cupsofcoffee
Copy link
Collaborator

17cupsofcoffee commented Mar 2, 2020

How does this look?

image

@AngelOnFira
Copy link
Member Author

@17cupsofcoffee Looks great! tbh wasn't 100% sure how I would execute, so 🙏

@ozkriff
Copy link
Member

ozkriff commented Mar 6, 2020

Images look to be slightly off to the right now on mobile:

image

@ozkriff ozkriff reopened this Mar 6, 2020
17cupsofcoffee added a commit that referenced this issue Mar 6, 2020
17cupsofcoffee added a commit that referenced this issue Mar 6, 2020
@17cupsofcoffee
Copy link
Collaborator

image

Looks okay now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants