Skip to content

Newsletter 7: Add Veloren February content #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AngelOnFira
Copy link
Member

@AngelOnFira AngelOnFira commented Mar 1, 2020

Part of #64 ("Newsletter 7: Coordination/Tracking")

This includes a Youtube iframe template. Hopefully it's ok to add.

@AngelOnFira AngelOnFira changed the title Add Veloren ebruary content Add Veloren February content Mar 1, 2020
@ozkriff
Copy link
Member

ozkriff commented Mar 1, 2020

This includes a Youtube iframe template. Hopefully it's ok to add.

Hmm. I've been deliberately trying to avoid everything that GitHub's Markdown render can't handle - so previews & diffs stay useful.

@17cupsofcoffee @Lokathor @AlexEne @erlend-sh - what do you think?

@AngelOnFira AngelOnFira changed the title Add Veloren February content Newsletter 7: Add Veloren February content Mar 1, 2020
@AlexEne
Copy link
Member

AlexEne commented Mar 1, 2020

I would go for the ease of preview, you can leave it as a link

@17cupsofcoffee
Copy link
Collaborator

I have no philosophical objection to including YouTube embeds in the newsletter, but would also slightly lean towards doing them in a way that shows up on GitHub's PR preview if at all possible.

If you put the embed HTML directly in the markdown file, does it show up on GitHub? If so, maybe we could keep the CSS classes and provide an example of how to use them in the 'ideal section structure' at the top of the newsletter template? Might be less maintainable though, somewhat torn 😅

@ozkriff
Copy link
Member

ozkriff commented Mar 1, 2020

If you put the embed HTML directly in the markdown file, does it show up on GitHub?

Nope, GitHub's Markdown doesn't support iframe:

<iframe width="560" height="315" src="https://www.youtube.com/embed/6tZByt4LBlU" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

@17cupsofcoffee
Copy link
Collaborator

Bah, understandable (would probably be a security nightmare) but annoying!

@AngelOnFira
Copy link
Member Author

I understand that it would be great to be able to preview what it looks like in the PR, but it really seems like we'd be shooting ourselves in the foot on this one. Youtube videos are a good standard of something that plays videos on the newsletter, and I imagine there will be times that this comes up again in the future.

As far as I can find, there isn't anything that can embed youtube videos into Github markdown without doing an external link.

@AlexEne
Copy link
Member

AlexEne commented Mar 2, 2020

There are a bunch of other youtube vids linked with normal links from the newsletter, so I think it's fine to leave this one with a link too (just like the others).

As a bonus it also makes for easier diffs like @ozkriff said.

You can add a small .gif that links to the youtube for example.

@ozkriff
Copy link
Member

ozkriff commented Mar 2, 2020

I usually used either GIFs or youtube screenshots for linking to videos.

@17cupsofcoffee
Copy link
Collaborator

Another potential consideration would be that if we allowed YouTube embeds, we'd have to strip them out if we ever started sending the newsletter out as an email, as most email clients block iframes. That kinda makes me lean towards @ozkriff's suggestion, although I agree it's not ideal to not have the videos inline.

@AngelOnFira
Copy link
Member Author

kk sounds good, I'll go for the gif option

@AngelOnFira AngelOnFira force-pushed the add-veloren-february-content branch from 4b009cf to 8ff5ac0 Compare March 2, 2020 21:39
@AngelOnFira
Copy link
Member Author

@ozkriff Should be good to go now :)

@AngelOnFira AngelOnFira mentioned this pull request Mar 2, 2020
@ozkriff ozkriff merged commit be859bb into rust-gamedev:source Mar 2, 2020
@AngelOnFira AngelOnFira deleted the add-veloren-february-content branch March 2, 2020 23:30
@ozkriff ozkriff mentioned this pull request Mar 2, 2020
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants