Skip to content

N33: Oasis of Lost Hope #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

N33: Oasis of Lost Hope #1022

merged 1 commit into from
May 12, 2022

Conversation

Bromeon
Copy link
Contributor

@Bromeon Bromeon commented May 8, 2022

Part of #1010

@Bromeon Bromeon mentioned this pull request May 8, 2022
Closed
38 tasks
ozkriff
ozkriff approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 though i'd be good to reduce the image size

@Bromeon
Copy link
Contributor Author

Bromeon commented May 9, 2022

though i'd be good to reduce the image size

Do you know any good tool for this? I already shrunk it from 1.4MB 😬

@ozkriff
Copy link
Member

ozkriff commented May 9, 2022

I'd convert it from png to jpg

@Bromeon
Copy link
Contributor Author

Bromeon commented May 9, 2022

Changed to .jpg, halved the size. I was first worried it would lose quality, but seems OK with this quantization.

@17cupsofcoffee
Copy link
Collaborator

For future reference, I usually use https://tinypng.com if I need to shrink a PNG without substantial quality loss :)

@AngelOnFira AngelOnFira merged commit a834026 into rust-gamedev:source May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bromeon @ozkriff @17cupsofcoffee @AngelOnFira