Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brontefy me #1069

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Brontefy me #1069

merged 5 commits into from
Jun 29, 2022

Conversation

hedgein
Copy link
Contributor

@hedgein hedgein commented Jun 28, 2022

Part of #1065
I hope it's okay to plug in my Discord server! Wanted to included it in case people wanted to hear more (really soon) updates about the state of Brontefy Me and its potential monthly game jam.

@AngelOnFira
Copy link
Member

Looks like we have some Mac artifacts with the .DS_Store, would be best to remove them :) also, can we reduce the image size? < 300KB is what we aim for 💯

@hedgein
Copy link
Contributor Author

hedgein commented Jun 28, 2022

f'sure! I will go ahead create a .git ignore then! let me also make the image size smaller!

@hedgein
Copy link
Contributor Author

hedgein commented Jun 28, 2022

correction: update the git ignore!

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to clean up, but looks good overall!

content/news/035/index.md Outdated Show resolved Hide resolved
content/news/035/index.md Outdated Show resolved Hide resolved
content/news/035/index.md Outdated Show resolved Hide resolved
content/news/035/index.md Outdated Show resolved Hide resolved
@AngelOnFira
Copy link
Member

correction: update the git ignore!

I feel like this came up in the past, @ozkriff was there a reason that we didn't already have .DS_Store in the git ignore?

.gitignore Show resolved Hide resolved
content/news/035/index.md Outdated Show resolved Hide resolved
content/news/035/index.md Outdated Show resolved Hide resolved
@17cupsofcoffee 17cupsofcoffee merged commit b0d7b9a into rust-gamedev:source Jun 29, 2022
@ozkriff
Copy link
Member

ozkriff commented Jul 4, 2022

I feel like this came up in the past, @ozkriff was there a reason that we didn't already have .DS_Store in the git ignore?

Stuff that isn't directly related to the project shouldn't be put to a global gitignore (as @Vrixyz said).
But I don't feel too strongly about this, let's keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants