Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N44: rust-gpu-sdf #1328

Merged
merged 4 commits into from
Apr 16, 2023
Merged

N44: rust-gpu-sdf #1328

merged 4 commits into from
Apr 16, 2023

Conversation

Shfty
Copy link
Contributor

@Shfty Shfty commented Apr 5, 2023

Part of #1317

Adds rust-gpu-sdf section to newsletter.

@Shfty Shfty force-pushed the n44-rust-gpu-sdf branch from 3b22272 to 7401164 Compare April 5, 2023 01:49
@AngelOnFira
Copy link
Member

This section is too long I think, coming in at 2000 characters on the rendered version:

image

I think that it is pretty condensed though, and it is neat to read. What are your thoughts @ozkriff? I'm thinking of leaving it as is, or just getting it to be decreased to ~1500 characters instead.

@Shfty
Copy link
Contributor Author

Shfty commented Apr 9, 2023

It is a bit wordy - if necessary I could probably chop it down without losing too much by merging paragraphs 1/2 and 3/4 and reducing the applications / implementation with some context links to wikipedia or such.

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's worth cutting the section a bit, currently it feels too long and detailed for the usual newsletter format

@Shfty Shfty force-pushed the n44-rust-gpu-sdf branch from 4801e2f to 80c4b0a Compare April 13, 2023 21:10
@Shfty Shfty requested a review from ozkriff April 13, 2023 21:12
@Shfty
Copy link
Contributor Author

Shfty commented Apr 13, 2023

I've edited it down to ~1200 characters - it's not quite so explicit about the applications and implementation details, but I've added a couple of links that should make up the difference for readers who aren't familiar with the field.

@ozkriff ozkriff merged commit 5f95644 into rust-gamedev:source Apr 16, 2023
@ozkriff
Copy link
Member

ozkriff commented Apr 16, 2023

Tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants