Skip to content

Add section about goods assets library #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2020
Merged

Conversation

zakarumych
Copy link
Contributor

It's the first time I write something like this, so just point me the issue ;)

@ozkriff asked to link it here #139

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few style nitpicks:

  1. Could you insert hard-wraps at 80 chars?
  2. There's a lot of short paragraphs, could you either merge some of them or convert to an explicit list, please?

@ozkriff ozkriff mentioned this pull request May 30, 2020
49 tasks
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (tweaked fmt a bit)

@ozkriff ozkriff merged commit 3e94755 into rust-gamedev:source May 30, 2020
@ozkriff
Copy link
Member

ozkriff commented May 30, 2020

Merged, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants