Newsletter 13: Add NeoCogi's libs #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17cupsofcoffee
requested changes
Aug 30, 2020
There was a problem hiding this comment.
There's a few formatting issues being flagged by the CI job:
content/posts/newsletter-013/index.md:69 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### NeoCogi's libraries"]
content/posts/newsletter-013/index.md:70:81 MD013/line-length Line length [Expected: 80; Actual: 214]
content/posts/newsletter-013/index.md:72 MD045/no-alt-text Images should have alternate text (alt text)
content/posts/newsletter-013/index.md:74:81 MD013/line-length Line length [Expected: 80; Actual: 99]
content/posts/newsletter-013/index.md:75:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:75 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* The new code should still in..."]
content/posts/newsletter-013/index.md:76:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:78:81 MD013/line-length Line length [Expected: 80; Actual: 185]
content/posts/newsletter-013/index.md:80:81 MD013/line-length Line length [Expected: 80; Actual: 135]
content/posts/newsletter-013/index.md:86 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
Changes that are needed to make the linter happy are:
- Add an extra line after the heading
- Add alt text for the images (goes inside the
[]for the image embed syntax) - Lines should not be longer than 80 characters
- Replace the
*with-for the list items - Add a line break above the list
- Remove one of the linebreaks before the next heading
17cupsofcoffee
approved these changes
Aug 31, 2020
|
Checks have passed, no merge conflicts, @ozkriff please validate! |
ozkriff
approved these changes
Sep 6, 2020
|
Merged, thanks for the PR! Good luck with the rest of RIIR! :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #232 ("Newsletter 13")