Skip to content

Newsletter 13: starframe #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2020
Merged

Newsletter 13: starframe #256

merged 2 commits into from
Sep 5, 2020

Conversation

m0lentum
Copy link
Contributor

@m0lentum m0lentum commented Sep 3, 2020

For #232

It's my first PR to a repo that isn't mine, so I guess this is a milestone of sorts for me :P

17cupsofcoffee
17cupsofcoffee reviewed Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

ozkriff
ozkriff approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit b46b76f into rust-gamedev:source Sep 5, 2020
@ozkriff
Copy link
Member

ozkriff commented Sep 5, 2020

Thanks and congrats on the first external PR! :)

@m0lentum m0lentum deleted the 13-starframe branch September 5, 2020 20:52
@ozkriff ozkriff mentioned this pull request Sep 6, 2020
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m0lentum @ozkriff @17cupsofcoffee