Skip to content

N17: starframe #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2021
Merged

N17: starframe #414

merged 3 commits into from
Jan 8, 2021

Conversation

m0lentum
Copy link
Contributor

@m0lentum m0lentum commented Jan 4, 2021

Part of #408

@ozkriff ozkriff mentioned this pull request Jan 5, 2021
Closed
ozkriff
ozkriff requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text itself LGTM, though the GIF is too large. In general, we try to keep GIFs under 2MBs. Could you optimize it a little bit?

GIFs should be <2MB in size (ezgif.com is a nice online tool for quick editing/optimization)

@m0lentum
Copy link
Contributor Author

m0lentum commented Jan 8, 2021

Sorry, I didn't read the contributing guide thoroughly enough. I couldn't get it under 2MB using ezgif's optimizer so I cut the length instead, should be good now

ozkriff
ozkriff approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit 2591817 into rust-gamedev:source Jan 8, 2021
@ozkriff
Copy link
Member

ozkriff commented Jan 8, 2021

Thanks, merged!

@m0lentum m0lentum deleted the n17-starframe branch January 8, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m0lentum @ozkriff @17cupsofcoffee