Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N20: pGLOWrpg #536

Merged
merged 6 commits into from
Apr 5, 2021
Merged

N20: pGLOWrpg #536

merged 6 commits into from
Apr 5, 2021

Conversation

roalyr
Copy link
Contributor

@roalyr roalyr commented Apr 4, 2021 •
edited by ozkriff
Loading

Part of #531

@17cupsofcoffee
Copy link
Collaborator

Also, there are a couple of formatting issues being flagged up by the linter:

content/posts/newsletter-020/index.md:76:81 MD013/line-length Line length [Expected: 80; Actual: 87]
content/posts/newsletter-020/index.md:76 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Reformatting a printing inte..."]

@roalyr
Copy link
Contributor Author

roalyr commented Apr 4, 2021

Are links still broken? I can only open my own Twitter link...

@17cupsofcoffee
Copy link
Collaborator

Ah, I was misremembering the syntax - to use reference-style links, you need square brackets on both parts:

  • [pGLOWrpg](pglowrpg-github) should be [pGLOWrpg][pglowrpg-github].
  • [Twiter](pglowrpg-twitter) should be [Twitter][pglowrpg-twitter].

17cupsofcoffee
17cupsofcoffee approved these changes Apr 4, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@roalyr
Copy link
Contributor Author

roalyr commented Apr 4, 2021

#531

@17cupsofcoffee 17cupsofcoffee merged commit 440bd0b into rust-gamedev:source Apr 5, 2021
@ozkriff ozkriff mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roalyr @17cupsofcoffee