Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N20: Fishgame and nakama-rs #572

Merged
merged 5 commits into from
Apr 7, 2021
Merged

N20: Fishgame and nakama-rs #572

merged 5 commits into from
Apr 7, 2021

Conversation

not-fl3
Copy link
Contributor

@not-fl3 not-fl3 commented Apr 7, 2021

ozkriff
ozkriff reviewed Apr 7, 2021
View reviewed changes
content/posts/newsletter-020/index.md
@@ -207,6 +207,27 @@ of the past 6 months of development.
[egregoria-discord]: https://discord.gg/CAaZhUJ
[egregoria-youtube]: https://youtu.be/qH2SKWbRV5I

### [Fishgame][fishgame]

![Fishgame](fishgame.gif)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no GIF in the PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh thanks

ozkriff
ozkriff requested changes Apr 7, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall except for a missing GIF

@ozkriff ozkriff mentioned this pull request Apr 7, 2021
Closed
@not-fl3
Copy link
Contributor Author

not-fl3 commented Apr 7, 2021

Fixed missing GIF :)

@ozkriff ozkriff merged commit b8d1e8d into rust-gamedev:source Apr 7, 2021
@ozkriff
Copy link
Member

ozkriff commented Apr 7, 2021

Merged, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@not-fl3 @ozkriff @17cupsofcoffee