Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N20: Release #583

Merged
merged 3 commits into from
Apr 10, 2021
Merged

N20: Release #583

merged 3 commits into from
Apr 10, 2021

Conversation

ozkriff
Copy link
Member

@ozkriff ozkriff commented Apr 10, 2021

Preview (4d55e74): https://rust-gamedev-preview.netlify.app/posts/newsletter-020

Everyone is invited to review!

⏲️ Merging this in ~4/5 hours if there're no objections.

Part of #531

Copy link
Contributor

@djkoloski djkoloski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the wrong plurality, oops! Everything looks really good otherwise. 🙂

content/posts/newsletter-020/index.md Show resolved Hide resolved
@kvark
Copy link
Collaborator

kvark commented Apr 10, 2021

e.g. posting issues on our github.

This contradicts the guidelines, I think. Shouldn't be written as "our".

Station Iapetus

Has both the image as a link, and the link in the image caption. Should the caption just say "click on the image to see the video", or the image be non-link instead?

Emerald

The image here doesn't need to be so big, since it's just a logo, it doesn't show any actual rendering.

Honestly, this entry is also a bit fishy... The news for Emerald are just these two tiny lines:

rendering to textures
WASM game sample.

While everything else is self-promotion and general information. I think the newsletter should put a stronger focus on the "news" part, and prevent parties from just using it to remind about themselves. I.e. something like "your news need to be at least as big as the general description" rule.

Similar concern could be applied to "Quinn" entry, although to a much lesser degree.

The "bevy" entry style is what I find to be the best, and every entry should try to follow the format.

In "wgpu" entry, something goes wrong about the image caption, it's not centered.

(such as #[allow(unused_attributes)])

Would be nice to codify this part (i.e. with "`")

based on the wgpu framework

nit: wgpu is a library, not a framework

@ozkriff
Copy link
Member Author

ozkriff commented Apr 10, 2021

@kvark, I've addressed most of the suggestions, thanks!

The news for Emerald are just these two tiny lines:
While everything else is self-promotion and general information. I think the newsletter should put a stronger focus on the "news" part, and prevent parties from just using it to remind about themselves. I.e. something like "your news need to be at least as big as the general description" rule.

This is the first newsletter issue that features Emerald's entry. It's ok that it focuses on a general overview.

Similar concern could be applied to "Quinn" entry, although to a much lesser degree.

Same with Quinn.

@ozkriff
Copy link
Member Author

ozkriff commented Apr 10, 2021

⏲️ Merging in 15 minutes.

@ozkriff ozkriff merged commit e8ac6b8 into rust-gamedev:source Apr 10, 2021
@kvark
Copy link
Collaborator

kvark commented Apr 10, 2021 via email

@ozkriff ozkriff deleted the n20_release branch April 10, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants