-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.10.4 broken compatibility with Rust 1.48 #645
Comments
@davidhewitt Does the problem persist in 0.10.5? |
Looking at 0.10.5 via the sources view of docs.rs [1] and comparing it to 0.10.4 [2], this looks resolved to me. [1] https://docs.rs/crate/itertools/0.10.5/source/Cargo.toml [2] https://docs.rs/crate/itertools/0.10.4/source/Cargo.toml |
CI using Rust 1.48 also looks good now. [1] I'd say this is resolved. [1] https://github.com/PyO3/pyo3/actions/runs/3239818816/jobs/5309679489 |
Yep, thanks very much for fixing! |
https://docs.rs/crate/itertools/0.10.4/source/Cargo.toml contains a
resolver
key, which was not stable on Rust 1.48 and causes build errors.Cargo.toml.orig
does not contain the key, so this was probably caused by releasing with a nightly or beta toolchain which contains the bug rust-lang/cargo#10954Would you please be willing to re-release as 0.10.5 with an updated Cargo toolchain?
The text was updated successfully, but these errors were encountered: