Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.4 broken compatibility with Rust 1.48 #645

Closed
davidhewitt opened this issue Sep 13, 2022 · 5 comments
Closed

0.10.4 broken compatibility with Rust 1.48 #645

davidhewitt opened this issue Sep 13, 2022 · 5 comments

Comments

@davidhewitt
Copy link

https://docs.rs/crate/itertools/0.10.4/source/Cargo.toml contains a resolver key, which was not stable on Rust 1.48 and causes build errors.

Cargo.toml.orig does not contain the key, so this was probably caused by releasing with a nightly or beta toolchain which contains the bug rust-lang/cargo#10954

Would you please be willing to re-release as 0.10.5 with an updated Cargo toolchain?

@phimuemue
Copy link
Member

phimuemue commented Sep 18, 2022

Hi there, thanks for the report.

@jswrenn I'm no expert on what cargo publish internally does, but I tried a --dry-run with cargo 1.63.0, and it seems that this one does not generate the resolver key in Cargo.toml. I pushed d61d12e - maybe you can cargo publish it?

asomers added a commit to asomers/mockall that referenced this issue Sep 18, 2022
@phimuemue
Copy link
Member

@davidhewitt Does the problem persist in 0.10.5?

@adamreichold
Copy link
Contributor

Looking at 0.10.5 via the sources view of docs.rs [1] and comparing it to 0.10.4 [2], this looks resolved to me.

[1] https://docs.rs/crate/itertools/0.10.5/source/Cargo.toml

[2] https://docs.rs/crate/itertools/0.10.4/source/Cargo.toml

@adamreichold
Copy link
Contributor

CI using Rust 1.48 also looks good now. [1] I'd say this is resolved.

[1] https://github.com/PyO3/pyo3/actions/runs/3239818816/jobs/5309679489

@davidhewitt
Copy link
Author

Yep, thanks very much for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants