-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifests with a resolver field will be published even if the MSRV is less than 1.51 #10954
Labels
C-bug
Category: bug
Command-package
P-high
Priority: High
regression-from-stable-to-beta
Regression in beta that previously worked in stable.
Comments
ehuss
added
P-high
Priority: High
Command-package
regression-from-stable-to-beta
Regression in beta that previously worked in stable.
labels
Aug 9, 2022
Yep, I think I still have the commit that did that in the reflog somewhere, I'll try and find it. |
bors
added a commit
that referenced
this issue
Aug 11, 2022
[BETA 1.64] Only override published resolver when the workspace is different ### What does this PR try to resolve? Ensures when publishing a package that uses an implicit `resolver = "1"` to maintain an MSRV before the `resolver` key was stabilized the implicitness is retained rather than being turned into an explicit setting. fixes #10954 (assuming that the workspace and its packages are configured with a consistent resolver) Note: this is a backport of #10961 to beta
Amanieu
added a commit
to Amanieu/libc
that referenced
this issue
Aug 11, 2022
bors
added a commit
to rust-lang/libc
that referenced
this issue
Aug 11, 2022
Bump to 0.2.131 to work around Cargo bug rust-lang/cargo#10954
bors
added a commit
to rust-lang/libc
that referenced
this issue
Aug 11, 2022
Bump to 0.2.131 to work around Cargo bug rust-lang/cargo#10954
TommyCpp
added a commit
to TommyCpp/opentelemetry-rust
that referenced
this issue
Aug 13, 2022
TommyCpp
added a commit
to TommyCpp/opentelemetry-rust
that referenced
this issue
Aug 13, 2022
TommyCpp
added a commit
to open-telemetry/opentelemetry-rust
that referenced
this issue
Aug 14, 2022
* fix(common): clippy issue raised by 1.63 * fix(common): nightly issues * fix(jaeger): take self reference for `collector_password` * fix(common): pin serde to 1.0142 as workaround of rust-lang/cargo#10954 * fix(doc): fix type link in docs
This was referenced Sep 2, 2022
This was referenced Sep 2, 2022
This was referenced Sep 17, 2022
tatref
pushed a commit
to tatref/libc
that referenced
this issue
Mar 20, 2023
Gmanboy
added a commit
to Gmanboy/opentelemetry-rust
that referenced
this issue
Aug 12, 2024
* fix(common): clippy issue raised by 1.63 * fix(common): nightly issues * fix(jaeger): take self reference for `collector_password` * fix(common): pin serde to 1.0142 as workaround of rust-lang/cargo#10954 * fix(doc): fix type link in docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: bug
Command-package
P-high
Priority: High
regression-from-stable-to-beta
Regression in beta that previously worked in stable.
Problem
On the recent nightly, it seems that cargo package and cargo publish always generate a resolver field, regardless of MSRV or edition.
This makes it impossible to compile on rustc versions such as 1.50, where the resolver field was unstable, even if the MSRV of the published crate is smaller than 1.51.
Probably related to #10911
cc @Nemo157
Steps
To reproduce:
Possible Solution(s)
No response
Notes
No response
Version
The text was updated successfully, but these errors were encountered: