Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest libc doesn't build on 1.47 #2866

Closed
TheBlueMatt opened this issue Aug 9, 2022 · 4 comments · Fixed by #2867
Closed

latest libc doesn't build on 1.47 #2866

TheBlueMatt opened this issue Aug 9, 2022 · 4 comments · Fixed by #2867
Assignees
@JohnTitor
Labels
C-bug Category: bug

Comments

@TheBlueMatt
Copy link

Looks like all our CI jobs are now failing with:

error: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.128/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature
@TheBlueMatt TheBlueMatt added the C-bug Category: bug label Aug 9, 2022
@aganders3
Copy link

aganders3 commented Aug 9, 2022 •
edited
Loading

I just ran into this as well (on 1.48, FWIW). It looks like an issue with packaging potentially due to this rust-lang/cargo#10954.

@TheBlueMatt
Copy link
Author

According to that bug its just an issue on nightly? So presumably whoever uploaded the latest libc just needs to do a bump+reupload using stable cargo, not nightly?

@aganders3
Copy link

Yes that's my understanding of the issue as well.

@TheBlueMatt TheBlueMatt mentioned this issue Aug 9, 2022
Merged
@JohnTitor JohnTitor self-assigned this Aug 9, 2022
@JohnTitor
Copy link
Member

I've yanked v0.2.128, will make a new release soon.

JohnTitor added a commit to JohnTitor/libc that referenced this issue Aug 9, 2022
@JohnTitor
Bump up to v0.2.129
a328e2b 
... because v0.2.128 has a Cargo bug: rust-lang#2866

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor JohnTitor mentioned this issue Aug 9, 2022
Merged
bors added a commit that referenced this issue Aug 9, 2022
@bors
Auto merge of #2867 - JohnTitor:0.2.129, r=JohnTitor
e9145c5 
Bump up to v0.2.129

... because v0.2.128 has a Cargo bug: #2866

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor JohnTitor linked a pull request Aug 9, 2022 that will close this issue
Bump up to v0.2.129 #2867
Merged
@bors bors closed this as completed in #2867 Aug 9, 2022
@aganders3 aganders3 mentioned this issue Aug 9, 2022
Closed
@JohnTitor JohnTitor mentioned this issue Aug 11, 2022
Merged
libguestfs pushed a commit to libguestfs/nbdkit that referenced this issue Nov 1, 2022
@asomers
Revert "rust: Add resolver feature"
dc55cac 
This reverts commit 539ee34.

This was a workaround for an upstream bug, but upstream has now fixed
the bug.  See rust-lang/libc#2866
libguestfs pushed a commit to libguestfs/nbdkit that referenced this issue Nov 18, 2022
@asomers @rwmjones
Revert "rust: Add resolver feature"
08230d8 
This reverts commit 539ee34.

This was a workaround for an upstream bug, but upstream has now fixed
the bug.  See rust-lang/libc#2866

(cherry picked from commit dc55cac)
tatref pushed a commit to tatref/libc that referenced this issue Mar 20, 2023
@JohnTitor @tatref
Bump up to v0.2.129
4fcdd1c 
... because v0.2.128 has a Cargo bug: rust-lang#2866

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTitor JohnTitor

Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump up to v0.2.129 JohnTitor/libc
3 participants
@TheBlueMatt @aganders3 @JohnTitor