This repository was archived by the owner on Dec 1, 2023. It is now read-only.
Beta fixes #87
Merged
Beta fixes #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db777e8. Conflicts: src/lib.rs
rand 0.3 depends on log 0.3, which is much closer to working on the beta channel; there's just one commit that has been merged but not yet released in order for it to work correctly.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc-serialize is one of the most heavily depended upon crates; 125 reverse dependencies when I last checked. Getting it compiling on the beta channel will make it a lot easier to get other crates that depend on it compiling on the beta channel.
To do so, we need to remove its dependency on the
convertfeature, which is waiting on rust-lang/rfcs#529 that seems to be in rapid development. We can do that by just reverting the commit that adds support to this feature, and then add it back later once convert is no longer feature-gated.The other fix is to simply update the dev dedpendency on
rand, to a newer version that depends on a newerlog.logalso doesn't quite build on beta channel yet, but there is already a commit in the repository that fixes that (rust-lang/log@93fac65cd), it just needs to be version bumped and released.