Skip to content
This repository was archived by the owner on Dec 1, 2023. It is now read-only.

Fix compilation error on Windows #90

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Fix compilation error on Windows #90

merged 1 commit into from
Mar 29, 2015

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 29, 2015

Introduced in #87

Better continuous integration would be great. It's the second time in three days that one of the official crates doesn't compile on Windows.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@tomaka tomaka changed the title Fix compilation error Fix compilation error on Windows Mar 29, 2015
@alexcrichton
Copy link
Contributor

Do you know if it's possible to enable continuous integration for windows? We'd love to support it, we just don't know where to find it other than hosting it ourselves :(

@alexcrichton
Copy link
Contributor

Thanks though!

alexcrichton added a commit that referenced this pull request Mar 29, 2015
Fix compilation error on Windows
@alexcrichton alexcrichton merged commit 8669570 into rust-lang-deprecated:master Mar 29, 2015
@tomaka tomaka deleted the patch-1 branch March 29, 2015 17:17
@tomaka
Copy link
Contributor Author

tomaka commented Mar 29, 2015

I'm using appveyor.
See for example what I do for glutin.

@tomaka
Copy link
Contributor Author

tomaka commented Mar 29, 2015

It works great, the only problem is that there's a ~10-15mn wait in the queue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants