Move date from file name to front matter #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the date in the file name, there are some name collisions.
These were resolved by inserting `@{counter}` before the file extension.
A later commit will adjust the static site generator to strip this
disambiguator again, such that permalinks stay intact.
The counter is sorted by date, i.e. `foo@0.md` is older than `foo@1.md`.
If a previous run of the static site generator created new files, these will be left lying around, even if subsequent runs wouldn't generate that file anymore. This will lead to either a false negative or a false positive. - The file shouldn't be generated and isn't. Tests incorrectly fail because it's still there. - The file should be generated but isn't. Tests incorrectly pass because it's still there.
Manishearth
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I snapshot tested this locally, the output is identical. As always, I made an effort to make the individual commits easy to review.
Motivations:
pathkey to the front matter, which contains the explicit URL with the date, in order to be able to migrate to Zola. It will be easier to keepdateandpathin sync. Firstly, because they will be right next to each other, making a discrepancy clearly visible. Secondly, because we already have the front matter strongly typed and tested, so it will be easy to add this simple validation on top.stacked on #1509
Rendered