-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for rustc plugins #13246
Labels
A-diagnostics
Area: Error and warning messages generated by Cargo itself.
C-feature-request
Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Comments
bjorn3
added
C-feature-request
Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
S-triage
Status: This issue is waiting on initial triage.
labels
Jan 3, 2024
I think it would be good, but I think we need to be a little cautious since I believe there are people abusing (or misunderstanding) the plugin setting to force building a dylib. We may need to do a deprecation notice for a little while. |
Opened #13248 for a deprecation warning. |
weihanglo
added
A-diagnostics
Area: Error and warning messages generated by Cargo itself.
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
and removed
S-triage
Status: This issue is waiting on initial triage.
labels
Jan 4, 2024
3 tasks
bors
added a commit
that referenced
this issue
Jun 9, 2024
fix(toml): remove `lib.plugin` key support and make it warning ### What does this PR try to resolve? Remove `lib.plugin` key, making it an "unused key" warning. Remove some of the tests, which should look useless (I hope I'm understanding this - [x] Remove key, and related tests. - [x] Adjust the documentation about the plugin. - [ ] Some of the comments and function names have not yet finished being modified. part of #13629 Closes #13246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Error and warning messages generated by Cargo itself.
C-feature-request
Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Problem
Cargo still supports building and depending on rustc plugins despite this having been removed from rustc a while ago.
Proposed Solution
Remove support for building rustc plugins.
Notes
Support was removed in rust-lang/rust#116412
The text was updated successfully, but these errors were encountered: