fix(toml): remove `lib.plugin` key support and make it warning #13902

heisen-li · 2024-05-11T09:41:15Z

What does this PR try to resolve?

Remove lib.plugin key, making it an "unused key" warning.

Remove some of the tests, which should look useless (I hope I'm understanding this

Remove key, and related tests.
Adjust the documentation about the plugin.
Some of the comments and function names have not yet finished being modified.

part of #13629

Closes #13246

rustbot · 2024-05-11T09:41:20Z

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

weihanglo

Could you do documentation update as well?

src/doc/src/reference/cargo-targets.md could just indicate that “This option is deprecated and unused”.
Change this line to “mostly for support of proc-macros”.
Any other comments or function names containing "plugin" that needs to be removed. You can hold of this a bit, as it might require extra efforts.

Personally the change is fine, though I still think it is great to ship this along with the version introduction edition 2024 (not tie to edition just merge this in the same version).

tests/testsuite/build_script.rs

tests/testsuite/cross_compile.rs

src/doc/src/reference/cargo-targets.md

weihanglo

Thanks! Could you squash doc commits into one, and test commits into another?

src/doc/src/reference/cargo-targets.md

weihanglo

Thanks!

It might not be necessary, though I'd like to wait a little longer. I'll merge this once nightly 1.81 is out.

weihanglo · 2024-06-09T17:13:27Z

@bors try

fix(toml): remove `lib.plugin` key support and make it warning ### What does this PR try to resolve? Remove `lib.plugin` key, making it an "unused key" warning. Remove some of the tests, which should look useless (I hope I'm understanding this - [x] Remove key, and related tests. - [x] Adjust the documentation about the plugin. - [ ] Some of the comments and function names have not yet finished being modified. part of #13629 Closes #13246

bors · 2024-06-09T17:14:35Z

⌛ Trying commit a969971 with merge 7da4ff3...

bors · 2024-06-09T17:40:14Z

☀️ Try build successful - checks-actions
Build commit: 7da4ff3 (7da4ff38acf173c760f362a25e3e38f3407ba13f)

weihanglo · 2024-06-09T17:40:38Z

@bors r+

Thanks!

bors · 2024-06-09T17:40:40Z

📌 Commit a969971 has been approved by weihanglo

It is now in the queue for this repository.

bors · 2024-06-09T18:07:58Z

⌛ Testing commit a969971 with merge 54d9c33...

bors · 2024-06-09T18:34:07Z

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 54d9c33 to master...

epage · 2024-06-10T14:47:08Z

Something was off about the timing of this and CI is now reporting a breaking change. We need to bump the version of cargo-util-schemas.

See https://github.com/rust-lang/cargo/actions/runs/9449610811/job/26026286907?pr=14037

See rust-lang#13902

chore: Bump cargo-util-schemas to 0.5 See #13902

Update cargo 14 commits in b1feb75d062444e2cee8b3d2aaa95309d65e9ccd..4dcbca118ab7f9ffac4728004c983754bc6a04ff 2024-06-07 20:16:17 +0000 to 2024-06-11 16:27:02 +0000 - Add local registry overlays (rust-lang/cargo#13926) - docs(change): Don't mention non-existent workspace.badges (rust-lang/cargo#14042) - test: migrate binary_name to snapbox (rust-lang/cargo#14041) - Bump to 0.82.0; update changelog (rust-lang/cargo#14040) - tests: Migrate alt_registry to snapbox (rust-lang/cargo#14031) - fix: proc-macro example from dep no longer affects feature resolution (rust-lang/cargo#13892) - chore: Bump cargo-util-schemas to 0.5 (rust-lang/cargo#14038) - chore(deps): update rust crate pulldown-cmark to 0.11.0 (rust-lang/cargo#14037) - fix: remove `__CARGO_GITOXIDE_DISABLE_LIST_FILES` env var (rust-lang/cargo#14036) - chore(deps): update rust crate itertools to 0.13.0 (rust-lang/cargo#13998) - fix(toml): remove `lib.plugin` key support and make it warning (rust-lang/cargo#13902) - chore(deps): update compatible (rust-lang/cargo#13995) - fix: using `--release/debug` and `--profile` together becomes an error (rust-lang/cargo#13971) - fix(toml): Convert warnings that `licence` and `readme` files do not exist into errors (rust-lang/cargo#13921) r? ghost

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | minor | `1.80.1` -> `1.81.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.81.0`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1810-2024-09-05) [Compare Source](rust-lang/rust@1.80.1...1.81.0) \========================== <a id="1.81.0-Language"></a> ## Language - [Abort on uncaught panics in `extern "C"` functions.](rust-lang/rust#116088) - [Fix ambiguous cases of multiple `&` in elided self lifetimes.](rust-lang/rust#117967) - [Stabilize `#[expect]` for lints (RFC 2383),](rust-lang/rust#120924) like `#[allow]` with a warning if the lint is *not* fulfilled. - [Change method resolution to constrain hidden types instead of rejecting method candidates.](rust-lang/rust#123962) - [Bump `elided_lifetimes_in_associated_constant` to deny.](rust-lang/rust#124211) - [`offset_from`: always allow pointers to point to the same address.](rust-lang/rust#124921) - [Allow constraining opaque types during subtyping in the trait system.](rust-lang/rust#125447) - [Allow constraining opaque types during various unsizing casts.](rust-lang/rust#125610) - [Deny keyword lifetimes pre-expansion.](rust-lang/rust#126762) <a id="1.81.0-Compiler"></a> ## Compiler - [Make casts of pointers to trait objects stricter.](rust-lang/rust#120248) - [Check alias args for well-formedness even if they have escaping bound vars.](rust-lang/rust#123737) - [Deprecate no-op codegen option `-Cinline-threshold=...`.](rust-lang/rust#124712) - [Re-implement a type-size based limit.](rust-lang/rust#125507) - [Properly account for alignment in `transmute` size checks.](rust-lang/rust#125740) - [Remove the `box_pointers` lint.](rust-lang/rust#126018) - [Ensure the interpreter checks bool/char for validity when they are used in a cast.](rust-lang/rust#126265) - [Improve coverage instrumentation for functions containing nested items.](rust-lang/rust#127199) - Target changes: - [Add Tier 3 `no_std` Xtensa targets:](rust-lang/rust#125141) `xtensa-esp32-none-elf`, `xtensa-esp32s2-none-elf`, `xtensa-esp32s3-none-elf` - [Add Tier 3 `std` Xtensa targets:](rust-lang/rust#126380) `xtensa-esp32-espidf`, `xtensa-esp32s2-espidf`, `xtensa-esp32s3-espidf` - [Add Tier 3 i686 Redox OS target:](rust-lang/rust#126192) `i686-unknown-redox` - [Promote `arm64ec-pc-windows-msvc` to Tier 2.](rust-lang/rust#126039) - [Promote `loongarch64-unknown-linux-musl` to Tier 2 with host tools.](rust-lang/rust#126298) - [Enable full tools and profiler for LoongArch Linux targets.](rust-lang/rust#127078) - [Unconditionally warn on usage of `wasm32-wasi`.](rust-lang/rust#126662) (see compatibility note below) - Refer to Rust's \[platform support page]\[platform-support-doc] for more information on Rust's tiered platform support. <a id="1.81.0-Libraries"></a> ## Libraries - [Split core's `PanicInfo` and std's `PanicInfo`.](rust-lang/rust#115974) (see compatibility note below) - [Generalize `{Rc,Arc}::make_mut()` to unsized types.](rust-lang/rust#116113) - [Replace sort implementations with stable `driftsort` and unstable `ipnsort`.](rust-lang/rust#124032) All `slice::sort*` and `slice::select_nth*` methods are expected to see significant performance improvements. See the [research project](https://github.com/Voultapher/sort-research-rs) for more details. - [Document behavior of `create_dir_all` with respect to empty paths.](rust-lang/rust#125112) - [Fix interleaved output in the default panic hook when multiple threads panic simultaneously.](rust-lang/rust#127397) <a id="1.81.0-Stabilized-APIs"></a> ## Stabilized APIs - [`core::error`](https://doc.rust-lang.org/stable/core/error/index.html) - [`hint::assert_unchecked`](https://doc.rust-lang.org/stable/core/hint/fn.assert_unchecked.html) - [`fs::exists`](https://doc.rust-lang.org/stable/std/fs/fn.exists.html) - [`AtomicBool::fetch_not`](https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicBool.html#method.fetch_not) - [`Duration::abs_diff`](https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.abs_diff) - [`IoSlice::advance`](https://doc.rust-lang.org/stable/std/io/struct.IoSlice.html#method.advance) - [`IoSlice::advance_slices`](https://doc.rust-lang.org/stable/std/io/struct.IoSlice.html#method.advance_slices) - [`IoSliceMut::advance`](https://doc.rust-lang.org/stable/std/io/struct.IoSliceMut.html#method.advance) - [`IoSliceMut::advance_slices`](https://doc.rust-lang.org/stable/std/io/struct.IoSliceMut.html#method.advance_slices) - [`PanicHookInfo`](https://doc.rust-lang.org/stable/std/panic/struct.PanicHookInfo.html) - [`PanicInfo::message`](https://doc.rust-lang.org/stable/core/panic/struct.PanicInfo.html#method.message) - [`PanicMessage`](https://doc.rust-lang.org/stable/core/panic/struct.PanicMessage.html) These APIs are now stable in const contexts: - [`char::from_u32_unchecked`](https://doc.rust-lang.org/stable/core/char/fn.from_u32\_unchecked.html) (function) - [`char::from_u32_unchecked`](https://doc.rust-lang.org/stable/core/primitive.char.html#method.from_u32\_unchecked) (method) - [`CStr::count_bytes`](https://doc.rust-lang.org/stable/core/ffi/c_str/struct.CStr.html#method.count_bytes) - [`CStr::from_ptr`](https://doc.rust-lang.org/stable/core/ffi/c_str/struct.CStr.html#method.from_ptr) <a id="1.81.0-Cargo"></a> ## Cargo - [Generated `.cargo_vcs_info.json` is always included, even when `--allow-dirty` is passed.](rust-lang/cargo#13960) - [Disallow `package.license-file` and `package.readme` pointing to non-existent files during packaging.](rust-lang/cargo#13921) - [Disallow passing `--release`/`--debug` flag along with the `--profile` flag.](rust-lang/cargo#13971) - [Remove `lib.plugin` key support in `Cargo.toml`. Rust plugin support has been deprecated for four years and was removed in 1.75.0.](rust-lang/cargo#13902) <a id="1.81.0-Compatibility-Notes"></a> ## Compatibility Notes - Usage of the `wasm32-wasi` target will now issue a compiler warning and request users switch to the `wasm32-wasip1` target instead. Both targets are the same, `wasm32-wasi` is only being renamed, and this [change to the WASI target](https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html) is being done to enable removing `wasm32-wasi` in January 2025. - We have renamed `std::panic::PanicInfo` to `std::panic::PanicHookInfo`. The old name will continue to work as an alias, but will result in a deprecation warning starting in Rust 1.82.0. `core::panic::PanicInfo` will remain unchanged, however, as this is now a *different type*. The reason is that these types have different roles: `std::panic::PanicHookInfo` is the argument to the [panic hook](https://doc.rust-lang.org/stable/std/panic/fn.set_hook.html) in std context (where panics can have an arbitrary payload), while `core::panic::PanicInfo` is the argument to the [`#[panic_handler]`](https://doc.rust-lang.org/nomicon/panic-handler.html) in no_std context (where panics always carry a formatted *message*). Separating these types allows us to add more useful methods to these types, such as `std::panic::PanicHookInfo::payload_as_str()` and `core::panic::PanicInfo::message()`. - The new sort implementations may panic if a type's implementation of [`Ord`](https://doc.rust-lang.org/std/cmp/trait.Ord.html) (or the given comparison function) does not implement a [total order](https://en.wikipedia.org/wiki/Total_order) as the trait requires. `Ord`'s supertraits (`PartialOrd`, `Eq`, and `PartialEq`) must also be consistent. The previous implementations would not "notice" any problem, but the new implementations have a good chance of detecting inconsistencies, throwing a panic rather than returning knowingly unsorted data. - [In very rare cases, a change in the internal evaluation order of the trait solver may result in new fatal overflow errors.](rust-lang/rust#126128) <a id="1.81.0-Internal-Changes"></a> ## Internal Changes These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add a Rust-for Linux `auto` CI job to check kernel builds.](rust-lang/rust#125209) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

rustbot assigned epage May 11, 2024

rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024

Muscraft mentioned this pull request May 11, 2024

Next step for deprecations in Cargo #13629

Open

13 tasks

heisen-li marked this pull request as draft May 12, 2024 02:43

heisen-li force-pushed the plugin branch 2 times, most recently from feda71e to 3638496 Compare May 13, 2024 09:07

heisen-li marked this pull request as ready for review May 13, 2024 11:15

weihanglo reviewed May 13, 2024

View reviewed changes

tests/testsuite/build_script.rs Show resolved Hide resolved

tests/testsuite/cross_compile.rs Show resolved Hide resolved

rustbot added the A-documenting-cargo-itself Area: Cargo's documentation label May 14, 2024

weihanglo reviewed May 15, 2024

View reviewed changes

src/doc/src/reference/cargo-targets.md Outdated Show resolved Hide resolved

weihanglo reviewed May 16, 2024

View reviewed changes

src/doc/src/reference/cargo-targets.md Show resolved Hide resolved

heisen-li added 3 commits May 16, 2024 20:03

fix(toml): remove lib.plugin key

1f48eab

remove or change lib.plugin related test

8056001

After deleting the key lib.plugin, modify the corresponding document.

a969971

heisen-li force-pushed the plugin branch from d813c58 to a969971 Compare May 16, 2024 12:25

weihanglo approved these changes May 20, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024

bors merged commit 54d9c33 into rust-lang:master Jun 9, 2024
13 of 21 checks passed

epage added a commit to epage/cargo that referenced this pull request Jun 10, 2024

chore: Bump cargo-util-schemas to 0.5

786ebe9

See rust-lang#13902

epage mentioned this pull request Jun 10, 2024

chore: Bump cargo-util-schemas to 0.5 #14038

Merged

bors added a commit that referenced this pull request Jun 10, 2024

Auto merge of #14038 - epage:schemas, r=weihanglo

d8f9130

chore: Bump cargo-util-schemas to 0.5 See #13902

weihanglo mentioned this pull request Jun 12, 2024

Update cargo rust-lang/rust#126290

Merged

heisen-li deleted the plugin branch June 12, 2024 06:44

rustbot added this to the 1.81.0 milestone Jun 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(toml): remove `lib.plugin` key support and make it warning #13902

fix(toml): remove `lib.plugin` key support and make it warning #13902

heisen-li commented May 11, 2024 •

edited

Loading

rustbot commented May 11, 2024

weihanglo left a comment

weihanglo left a comment

weihanglo left a comment

weihanglo commented Jun 9, 2024

bors commented Jun 9, 2024

bors commented Jun 9, 2024

weihanglo commented Jun 9, 2024

bors commented Jun 9, 2024

bors commented Jun 9, 2024

bors commented Jun 9, 2024

epage commented Jun 10, 2024

fix(toml): remove lib.plugin key support and make it warning #13902

fix(toml): remove lib.plugin key support and make it warning #13902

Conversation

heisen-li commented May 11, 2024 • edited Loading

What does this PR try to resolve?

rustbot commented May 11, 2024

weihanglo left a comment

Choose a reason for hiding this comment

weihanglo left a comment

Choose a reason for hiding this comment

weihanglo left a comment

Choose a reason for hiding this comment

weihanglo commented Jun 9, 2024

bors commented Jun 9, 2024

bors commented Jun 9, 2024

weihanglo commented Jun 9, 2024

bors commented Jun 9, 2024

bors commented Jun 9, 2024

bors commented Jun 9, 2024

epage commented Jun 10, 2024

fix(toml): remove `lib.plugin` key support and make it warning #13902

fix(toml): remove `lib.plugin` key support and make it warning #13902

heisen-li commented May 11, 2024 •

edited

Loading