Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --edition to rustdoc when an edition is configured #5279

Closed
QuietMisdreavus opened this issue Apr 2, 2018 · 2 comments · Fixed by #5299
Closed

Pass --edition to rustdoc when an edition is configured #5279

QuietMisdreavus opened this issue Apr 2, 2018 · 2 comments · Fixed by #5299

Comments

@QuietMisdreavus
Copy link
Member

In rust-lang/rust#49451 i added an --edition flag to rustdoc that made it compile crates and doctests in the given edition. Cargo should be extended to call this flag when an edition is present in a project's Cargo.toml.

At present the flag is unstable, so a -Z unstable-options will need to be passed to rustdoc for it to work properly. I'm not sure how cargo handles the flag for rustc, but i imagine something similar should happen for rustdoc.
@ehuss
Copy link
Contributor

ehuss commented Apr 4, 2018

I can work on this if you'd like.

@matklad
Copy link
Member

matklad commented Apr 5, 2018

Thant would be awesome @ehuss !

ehuss added a commit to ehuss/cargo that referenced this issue Apr 5, 2018
@ehuss
Pass edition to rustdoc.
bbb2b92 
Fixes rust-lang#5279.
@ehuss ehuss mentioned this issue Apr 5, 2018
Merged
bors added a commit that referenced this issue Apr 5, 2018
@bors
Auto merge of #5299 - ehuss:rustdoc-edition, r=matklad
b9aa315 
Pass edition to rustdoc.

Fixes #5279.
@bors bors closed this as completed in #5299 Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass edition to rustdoc. ehuss/cargo
3 participants
@ehuss @matklad @QuietMisdreavus