Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass edition to rustdoc. #5299

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Pass edition to rustdoc. #5299

merged 3 commits into from
Apr 5, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 5, 2018

Fixes #5279.

.build();

assert_that(
p.cargo("doc").arg("-v").masquerade_as_nightly_cargo(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write this compactly as p.cargo("doc -v").masquerade_as_nightly_cargo(), cargo function does simple argument splitting.

@matklad
Copy link
Member

matklad commented Apr 5, 2018

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 5, 2018

📌 Commit 187bb0a has been approved by matklad

@bors
Copy link
Contributor

bors commented Apr 5, 2018

⌛ Testing commit 187bb0a with merge f81a1fa633620cde1d93467714a06498d33e568f...

@bors
Copy link
Contributor

bors commented Apr 5, 2018

💔 Test failed - status-travis

@matklad
Copy link
Member

matklad commented Apr 5, 2018

Test failure seems legit. Perhaps the nightly at travis is too old?

@ehuss
Copy link
Contributor Author

ehuss commented Apr 5, 2018

Test failure seems legit. Perhaps the nightly at travis is too old?

Indeed it is too old. Perhaps now that rust-lang/rust#49033 is fixed we can switch back to regular "nightly" channel?

@matklad
Copy link
Member

matklad commented Apr 5, 2018

@ehuss probably! I have no time to actually investigate this, could you perhaps just try to change CI configuration in this PR?

Removes temporary workaround for rust-lang/rust#49033.
@ehuss
Copy link
Contributor Author

ehuss commented Apr 5, 2018

@matklad Looks like everything is passing now. Let me know if you want the CI changes in a separate PR, or if it's OK to ride on this one.

@matklad
Copy link
Member

matklad commented Apr 5, 2018

@bors r+

:)

@bors
Copy link
Contributor

bors commented Apr 5, 2018

📌 Commit 4eb42cd has been approved by matklad

bors added a commit that referenced this pull request Apr 5, 2018
@bors
Copy link
Contributor

bors commented Apr 5, 2018

⌛ Testing commit 4eb42cd with merge b9aa315...

@bors
Copy link
Contributor

bors commented Apr 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing b9aa315 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass --edition to rustdoc when an edition is configured
3 participants