-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass edition to rustdoc. #5299
Pass edition to rustdoc. #5299
Conversation
tests/testsuite/doc.rs
Outdated
.build(); | ||
|
||
assert_that( | ||
p.cargo("doc").arg("-v").masquerade_as_nightly_cargo(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can write this compactly as p.cargo("doc -v").masquerade_as_nightly_cargo()
, cargo
function does simple argument splitting.
@bors r+ Thanks! |
📌 Commit 187bb0a has been approved by |
⌛ Testing commit 187bb0a with merge f81a1fa633620cde1d93467714a06498d33e568f... |
💔 Test failed - status-travis |
Test failure seems legit. Perhaps the nightly at travis is too old? |
Indeed it is too old. Perhaps now that rust-lang/rust#49033 is fixed we can switch back to regular "nightly" channel? |
@ehuss probably! I have no time to actually investigate this, could you perhaps just try to change CI configuration in this PR? |
Removes temporary workaround for rust-lang/rust#49033.
@matklad Looks like everything is passing now. Let me know if you want the CI changes in a separate PR, or if it's OK to ride on this one. |
@bors r+ :) |
📌 Commit 4eb42cd has been approved by |
Pass edition to rustdoc. Fixes #5279.
☀️ Test successful - status-appveyor, status-travis |
Fixes #5279.