Add run-fail
to semver-check for docs
#10287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this missing feature in #10276 and therefore added it here in this separate PR.
If the breaking change does not involve a compilation error but a change in runtime behaviour, you can add
run-fail
to the codeblock. The "before" code must return exit code 0, and the "after" code must be nonzero (like a panic).Example case that I tested (ignore the trailing dot, it's for github markdown to not hate me)