Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update checkout action on CI #10521

Merged
merged 1 commit into from
Apr 2, 2022
Merged

tools: update checkout action on CI #10521

merged 1 commit into from
Apr 2, 2022

Conversation

UltiRequiem
Copy link
Contributor

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@ehuss
Copy link
Contributor

ehuss commented Apr 1, 2022

Thanks! I'm curious, can you say why you are opening these PRs on rust-lang projects? There isn't anything obvious in the changelog that seems like it would be needed. I can't imagine that GitHub would remove their node12 support in the foreseeable future as that would break almost everything.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2022

📌 Commit 095f403 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2022
@bors
Copy link
Contributor

bors commented Apr 1, 2022

⌛ Testing commit 095f403 with merge b1603eb...

@bors
Copy link
Contributor

bors commented Apr 2, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing b1603eb to master...

@bors bors merged commit b1603eb into rust-lang:master Apr 2, 2022
@UltiRequiem
Copy link
Contributor Author

can you say why you are opening these PRs on rust-lang projects?

I was just reading the codebase and thought updating this would be cool.

@ehuss ehuss mentioned this pull request Apr 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 6, 2022
@bors
Auto merge of rust-lang#95720 - ehuss:update-cargo, r=ehuss
ce1a813 
Update cargo

5 commits in 1ef1e0a12723ce9548d7da2b63119de9002bead8..e2e2dddebe66dfc1403a312653557e332445308b
2022-03-31 00:17:18 +0000 to 2022-04-05 17:04:53 +0000
- Part 2 of RFC2906 -- allow inheriting from a different `Cargo.toml` (rust-lang/cargo#10517)
- File Cache is valid if checkout or contents hasn't changed (rust-lang/cargo#10507)
- Fix how scrape-examples handles proc macros (rust-lang/cargo#10533)
- tools: update checkout action on CI (rust-lang/cargo#10521)
- Don't error if no binaries were installed (rust-lang/cargo#10508)
@ehuss ehuss added this to the 1.62.0 milestone Apr 7, 2022
@ehuss ehuss mentioned this pull request Apr 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
4 participants
@UltiRequiem @rust-highfive @ehuss @bors