Fix how scrape-examples handles proc macros #10533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR fixes #10500.
Previously, the scrape-examples extension did some shenanigans in
build_unit_dependencies
in order to scrapeproc-macro
crates. But this code is useless sinceproc-macro
crates cannot export functions, so we avoid this issue entirely by filtering proc-macro targets.How should we test and review this PR?
I added the test
scrape_examples_configure_profile
to ensure that the issue in #10500 is fixed.r? @ehuss