Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better suggestion for the unsupported silent flag #12723

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

Rustin170506
Copy link
Member

What does this PR try to resolve?

ref #11702

Added a better suggestion for the unsupported silent flag.

How should we test and review this PR?

Check out the unit tests.

Additional information

r? @weihanglo

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023
@Rustin170506 Rustin170506 marked this pull request as draft September 22, 2023 03:31
src/cargo/util/command_prelude.rs Outdated Show resolved Hide resolved
src/cargo/util/command_prelude.rs Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 force-pushed the rustin-patch-silent branch 2 times, most recently from 54ba72b to 8ae23fd Compare September 26, 2023 12:53
@Rustin170506 Rustin170506 marked this pull request as ready for review September 28, 2023 01:27
@weihanglo
Copy link
Member

Looks nice. Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

📌 Commit 5d8009a has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors
Copy link
Collaborator

bors commented Sep 28, 2023

⌛ Testing commit 5d8009a with merge 0438b9c...

bors added a commit that referenced this pull request Sep 28, 2023
Add better suggestion for the unsupported silent flag
@bors
Copy link
Collaborator

bors commented Sep 28, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2023
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

📌 Commit 44d955b has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2023
@bors
Copy link
Collaborator

bors commented Sep 28, 2023

⌛ Testing commit 44d955b with merge e3acdd3...

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing e3acdd3 to master...

@bors bors merged commit e3acdd3 into rust-lang:master Sep 28, 2023
20 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2023
Update cargo

4 commits in e6aabe8b3fcf639be3a5bf68e77853bd7b3fa27d..59596f0f31a94fde48b5aa7e945cd0b7ceca9620
2023-09-26 16:31:53 +0000 to 2023-09-29 19:29:17 +0000
- refactor: Switch from termcolor to anstream (rust-lang/cargo#12751)
- Add missing `strip` entries in `dev` and `release` profiles. (rust-lang/cargo#12748)
- Add better suggestion for the unsupported silent flag (rust-lang/cargo#12723)
- docs(ref): Establish publish best practices (rust-lang/cargo#12745)

r? ghost
@ehuss ehuss added this to the 1.74.0 milestone Sep 30, 2023
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 30, 2023
Update cargo

4 commits in e6aabe8b3fcf639be3a5bf68e77853bd7b3fa27d..59596f0f31a94fde48b5aa7e945cd0b7ceca9620
2023-09-26 16:31:53 +0000 to 2023-09-29 19:29:17 +0000
- refactor: Switch from termcolor to anstream (rust-lang/cargo#12751)
- Add missing `strip` entries in `dev` and `release` profiles. (rust-lang/cargo#12748)
- Add better suggestion for the unsupported silent flag (rust-lang/cargo#12723)
- docs(ref): Establish publish best practices (rust-lang/cargo#12745)

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. Command-vendor S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants