Add missing strip entries in dev and release profiles.
#12748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for the `dev` and `release` profiles mention 10 of the 11 possible profile settings. This commit adds the missing `strip` entries.
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-documenting-cargo-itself
weihanglo
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Nice catch. Thanks!
I am just about to submit exactly the same PR 😆.
For the reference, this comes from Profile::default():
cargo/src/cargo/core/profiles.rs
Lines 603 to 623 in e6aabe8
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2023
Update cargo 4 commits in e6aabe8b3fcf639be3a5bf68e77853bd7b3fa27d..59596f0f31a94fde48b5aa7e945cd0b7ceca9620 2023-09-26 16:31:53 +0000 to 2023-09-29 19:29:17 +0000 - refactor: Switch from termcolor to anstream (rust-lang/cargo#12751) - Add missing `strip` entries in `dev` and `release` profiles. (rust-lang/cargo#12748) - Add better suggestion for the unsupported silent flag (rust-lang/cargo#12723) - docs(ref): Establish publish best practices (rust-lang/cargo#12745) r? ghost
nnethercote
added a commit
to nnethercote/cargo
that referenced
this pull request
Sep 30, 2023
This is a follow-up to rust-lang#12748.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Sep 30, 2023
Update cargo 4 commits in e6aabe8b3fcf639be3a5bf68e77853bd7b3fa27d..59596f0f31a94fde48b5aa7e945cd0b7ceca9620 2023-09-26 16:31:53 +0000 to 2023-09-29 19:29:17 +0000 - refactor: Switch from termcolor to anstream (rust-lang/cargo#12751) - Add missing `strip` entries in `dev` and `release` profiles. (rust-lang/cargo#12748) - Add better suggestion for the unsupported silent flag (rust-lang/cargo#12723) - docs(ref): Establish publish best practices (rust-lang/cargo#12745) r? ghost
nnethercote
added a commit
to nnethercote/cargo
that referenced
this pull request
Oct 1, 2023
Also change some `strip = false` mentions to `strip = "false"`. This is a follow-up to rust-lang#12748.
bors
added a commit
that referenced
this pull request
Oct 1, 2023
Add more missing `strip` info to docs. This is a follow-up to #12748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for the
devandreleaseprofiles mention 10 of the 11 possible profile settings. This commit adds the missingstripentries.