Migrate rustfix to the cargo repo

[ehuss]

This migrates the rustfix crate from https://github.com/rust-lang/rustfix/ to the cargo repo. The cargo team has been responsible for the client-side of cargo fix, and it can make it easier to maintain with all our tooling and tracking here. This crate is used by some external parties (like the compiler), so it will need to be maintained like an "ecosystem" package, but hopefully there shouldn't be any outside requirements (I haven't seen any in several years).

After merging, I'll follow up with some things to address in the future, such as:

• Migrating issues from the other repo.
• Opening new issues for some cleanup tasks, such as adding documentation, fixing the #[ignore] annotations, fixing testing on windows, maybe migrating the test code to use different dependencies, various code cleanup.
• Archiving the repo.

[weihanglo]

Not blockers just call them out.

• Do we want a A-rustfix label or just accommendate them in Command-fix?
• We would like to update [autolabel] in triagebot.toml as well.
• Update places mentioning rusfix in Cargo Contributor Guide
  • https://doc.crates.io/contrib/issues.html#filing-issues

[weihanglo]

This command is failing cargo bump-check CI job:

cargo semver-checks -p rustfix --baseline-rev 1d8b05cdd1287c64467306cf3ca2c8ac60c11eb0

Seems like there is already a report in cargo-semver-checks: obi1kenobi/cargo-semver-checks#481

The scenario is a newly added package missing in the baseline version.

[weihanglo]

We might want to exclude rustfix from baseline check for now. Once rustfix-in-cargo hit stable (or beta if we want robustness), we can add it back.

diff --git a/crates/xtask-bump-check/src/xtask.rs b/crates/xtask-bump-check/src/xtask.rs
index cba420f051b..932d3ad1946 100644
--- a/crates/xtask-bump-check/src/xtask.rs
+++ b/crates/xtask-bump-check/src/xtask.rs
@@ -166,6 +166,7 @@ fn bump_check(args: &clap::ArgMatches, config: &cargo::util::Config) -> CargoRes
         let mut cmd = ProcessBuilder::new("cargo");
         cmd.arg("semver-checks")
             .arg("--workspace")
+            .args(&["--exclude", "rustfix"])
             .arg("--baseline-rev")
             .arg(referenced_commit.id().to_string());
         config.shell().status("Running", &cmd)?;

[ehuss]

Thanks for catching all the things I missed!

Do we want a A-rustfix label or just accommendate them in Command-fix?

I think for now I would prefer to just keep one label (Command-fix). I think in practice it is unlikely we will want to try to distinguish between the two, and it would make it a little more awkward to find issues because you would need to include both in your query.

We would like to update [autolabel] in triagebot.toml as well.

Added.

Update places mentioning rusfix in Cargo Contributor Guide

Updated.

We might want to exclude rustfix from baseline check for now. Once rustfix-in-cargo hit stable (or beta if we want robustness), we can add it back.

I have applied your patch.

[weihanglo]

Thank you ehuss for the migration!

@bors r+

[bors]

📌 Commit 47c7ff0 has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 47c7ff0 with merge eed300d...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing eed300d to master...