-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new kind=
syntax for libs throughout Cargo
#1405
Conversation
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
@@ -173,7 +173,7 @@ pub fn compile_targets<'a, 'b>(env: &str, | |||
|
|||
for (&(ref pkg, _), output) in cx.build_state.outputs.lock().unwrap().iter() { | |||
let any_dylib = output.library_links.iter().any(|l| { | |||
!l.ends_with(":static") && !l.ends_with(":framework") | |||
!l.ends_with("static=") && !l.ends_with("framework=") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ends_with
=> starts_with
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dear... that's only a little embarrasing
756f2f6
to
279c030
Compare
279c030
to
154efe4
Compare
☔ The latest upstream changes (presumably #1458) made this pull request unmergeable. Please resolve the merge conflicts. |
This should inadvertently fix rust-lang#1401
154efe4
to
7756fe6
Compare
This should inadvertently fix #1401
💔 Test failed - cargo-win-64 |
@bors: retry On Thu, Mar 26, 2015 at 2:53 PM, bors notifications@github.com wrote:
|
⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32 are reusable. Rebuilding only cargo-win-64... |
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
This should inadvertently fix #1401