Consider public dependencies when choosing a version in cargo add (#1… #15966

sadmac7000 · 2025-09-15T05:37:42Z

What does this PR try to resolve?

This change considers public dependencies when adding a new dependency. For example, if you depend on foo, which depends publicly on bar 1.0, and you run cargo add bar, you will now get bar 1.0 even if bar 2.0 is available.

Fixes #13038

How to test and review this PR?

The test suite has been updated with an example scenario. More tests might be warrented to see how this interacts with other features though.

rustbot · 2025-09-15T05:37:47Z

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

src/cargo/ops/cargo_add/mod.rs

tests/testsuite/cargo_add/mod.rs

src/cargo/util/toml_mut/manifest.rs

src/cargo/ops/cargo_add/mod.rs

The new method get_dependencies doesn't take a dep key but instead returns all deps. We'll sometimes need this in coming patches, and when we don't need it it's easy to have the caller filter.

epage · 2025-09-22T16:11:20Z

tests/testsuite/cargo_add/public_common_version/stderr.term.svg

By resolving before Adding, the output becomes unclear where the locking ends and the manifest editing begins

Since this is unstable, we could possibly punt on this

Someone also suggested trying to read the lockfile rather than doing a full resolve when possible, but yeah I think this might just be an area for further improvement.

Noted this on the tracking issue, #6129

src/cargo/ops/cargo_add/mod.rs

…st-lang#13038)

epage · 2025-10-06T17:23:37Z

Thanks!

Update cargo submodule 22 commits in 801d9b4981dd07e3aecdca1ab86834c13615737e..81c3f77a467359c8be6bc747dc93ec66a6e4ce11 2025-10-04 13:30:15 +0000 to 2025-10-10 18:41:02 +0000 - docs(changelog): literal host-tuple support (rust-lang/cargo#16033) - refactor: Define cargo script's target-dir using build-dir templating (rust-lang/cargo#16073) - feat(build-dir): Reorganize build-dir layout (rust-lang/cargo#15947) - refactor: unflatten `(String, Def)` to `ConfigValue` (rust-lang/cargo#16084) - fix(tree): Switch from `--depth public` to `--edges public` (rust-lang/cargo#16081) - docs(guide): Point out tools for reducing dependencies (rust-lang/cargo#16078) - Allow to rustfix unused_variables lint. (rust-lang/cargo#16082) - Fix test that assumes `CARGO_CFG_TARGET_FAMILY` is a single value (rust-lang/cargo#16079) - Fix regression that swallowed json diagnostic explanations (rust-lang/cargo#16075) - docs(ref): fix link to clippy incompatible_msrv lint (rust-lang/cargo#16077) - Convert a few more diagnostics to reports (rust-lang/cargo#16066) - fix(support): Add track_caller to know the actual failure (rust-lang/cargo#16069) - fix(add): Report a missing source error for workspace dependencies (rust-lang/cargo#16063) - fix(script): Default bin.name to package.name (rust-lang/cargo#16064) - refactor(gctx): ConfigValue getter cleanup (rust-lang/cargo#16067) - Fix unsafe_op_in_unsafe_fn for Windows (rust-lang/cargo#16058) - Consider public dependencies when choosing a version in cargo add (rust-lang/cargo#1… (rust-lang/cargo#15966) - docs: clarify panic-immediate-abort can be used in config (rust-lang/cargo#16054) - fix(timings): compute codegen start time to draw dep lines (rust-lang/cargo#16055) - chore: Added tracing span for build script execution (rust-lang/cargo#16053) - test: null-terminated path for reserved windows name detection (rust-lang/cargo#16052) - feat (publish): deprecate `--token` option (rust-lang/cargo#16046) r? ghost

rustbot assigned epage Sep 15, 2025

rustbot added A-manifest Area: Cargo.toml issues Command-add S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2025