Convert a few more diagnostics to reports

[jneem]

Here I'm continuing to slowly work through multi-part diagnostics and convert them to reports.

Like #16035, this converts a warning + note into a single Group with a warning title containing note elements. Based on this comment I'm not sure if this is actually what you want, mostly because these notes are typically shorter than the ones in #16035.

For comparison, I'll open another PR that does multiple groups. Edit: #16065

This is part of #15944

[rustbot]

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jneem]

Slightly off-topic, but I wanted to attach a manifest/config location here. It's a bit tricky, though, because the dependency table was the result of a merge between configs and manifests. How would you feel about having Dependency (and potentially other things) keep track of their source location?

[epage]

Really look forward to us adding more context like this though don't feel obligated to do so. This effort is more prep work for us to start doing these kinds of improvements. The most I expected to be done with this is wording changes to better fit the new style.

[epage]

---- cache_lock::shared_then_download stdout ----

thread 'cache_lock::shared_then_download' (9512) panicked at C:\a\cargo\cargo\crates\cargo-test-support\src\lib.rs:1618:13:
test did not finish within 10 attempts (1.0037207s total)


failures:
    cache_lock::shared_then_download

[epage]

@jneem do you have a preference for which route we go?

[jneem]

Not really, I'll happily continue with whichever you prefer.

[epage]

I think @Muscraft was leaning towards this one. Mind switching it to secondary_title and we can merge it?

Also, feel free to change notes that offer suggestions to being help, leaving note for when its adding more context. I know I keep going back and forth on this. Largely, my priority is in minimizing the work in migrating and the amount of things to hash out in reviews (since we may need to hash out wording which is bad enough). We can always re-evaluate these later. So this is more of a "if it works for you" and I won't be blocking any PRs as part of this effort on them having notes when they could be helps. As an example, "if possible, try a compatible non-yanked version" could be a help (but not requiring that to be changed).

[jneem]

Sounds good, I converted this to secondary_title and changed a couple notes to helps.

[epage]

Thanks!