Add configuration keys for -v, --color #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this pull request
Feb 19, 2016
This commit adds a more principled system to rationalize what ends up being a configuration value versus an environment variable. This problem is solved by just saying that they're one and the same! Similar to Bundler, this commit supports overriding the `foo.bar` configuration value with the `CARGO_FOO_BAR` environment variable. Currently this is used as part of the `get_string` and `get_i64` methods on `Config`. This means, for example, that the following environment variables can now be used to configure Cargo: * CARGO_BUILD_JOBS * CARGO_HTTP_TIMEOUT * CARGO_HTTP_PROXY Currently it's not supported to encode a list in an environment variable, so for example `CARGO_PATHS` would not be read when reading the global `paths` configuration value. cc rust-lang#2362 cc rust-lang#2395 -- intended to close this in tandem with rust-lang#2397
|
Got a chance to talk about this with @wycats today and the conclusions were:
|
alexcrichton
force-pushed
the
config-verbose
branch
from
c24c3bf
to
575d67b
Compare
bors
added a commit
that referenced
this pull request
Feb 26, 2016
This commit adds a more principled system to rationalize what ends up being a configuration value versus an environment variable. This problem is solved by just saying that they're one and the same! Similar to Bundler, this commit supports overriding the `foo.bar` configuration value with the `CARGO_FOO_BAR` environment variable. Currently this is used as part of the `get_string` and `get_i64` methods on `Config`. This means, for example, that the following environment variables can now be used to configure Cargo: * CARGO_BUILD_JOBS * CARGO_HTTP_TIMEOUT * CARGO_HTTP_PROXY Currently it's not supported to encode a list in an environment variable, so for example `CARGO_PATHS` would not be read when reading the global `paths` configuration value. cc #2362 cc #2395 -- intended to close this in tandem with #2397
|
@bors r+ |
|
📌 Commit 575d67b has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #2398) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
config-verbose
branch
from
575d67b
to
936e9b3
Compare
This commit adds configuration keys for:
[term]
verbose = true
color = 'auto'
These are all meant to be proxies for the command line flags but configured on a
global basis if desired.
alexcrichton
force-pushed
the
config-verbose
branch
from
936e9b3
to
be48d5b
Compare
alexcrichton
changed the title
bors
added a commit
that referenced
this pull request
Feb 26, 2016
This commit adds configuration keys for:
[term]
verbose = true
color = 'auto'
These are all meant to be proxies for the command line flags but configured on a
global basis if desired.
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds configuration keys for:
These are all meant to be proxies for the command line flags but configured on a
global basis if desired.