add .cargo/config settings to control output colors #2367
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2290
This is my first time submitting a Rust PR, so please give me lots of corrections. An example
~/.cargo/config
file setting these options would be:I picked the config names more or less at random, so I'm happy to change those. I went with the simple approach of adding an extra condition to our current use of
Attr::Bold
, but we could also consider letting the color strings represent boldness/brightness on their own.Naive question for the folks who know more about Rust and this code: why is it that
Config
contains a bunch ofRefCell
s rather than owning its data directly?