Tweak UI for warnings and errors #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
@bors r+ |
|
📌 Commit 30a7b88 has been approved by |
|
⌛ Testing commit 30a7b88 with merge 4d65c9b... |
|
💔 Test failed - cargo-linux-64 |
|
@bors: r+ |
|
📌 Commit 4dad102 has been approved by |
|
⌛ Testing commit 4dad102 with merge 2744e0c... |
|
💔 Test failed - cargo-mac-32 |
alexcrichton
force-pushed
the
ui
branch
2 times, most recently
from
25b5375
to
c14da2f
Compare
|
@bors: r=brson |
|
📌 Commit c14da2f has been approved by |
|
⌛ Testing commit c14da2f with merge 3569903... |
Right now Cargo prints out errors justified like all other status messages, but this can look odd without coloration: ``` error some error message ``` Instead, this commit changes both warnings and errors to use the same style of: ``` error: some error message warning: some warning message ``` Additionally, warnings now only print out "warning" in yellow instead of the entire message (like errors do)
|
@bors: r+ |
|
📌 Commit 8b35fbd has been approved by |
bors
added a commit
that referenced
this pull request
Mar 17, 2016
Tweak UI for warnings and errors Right now Cargo prints out errors justified like all other status messages, but this can look odd without coloration: ``` error some error message ``` Instead, this commit changes both warnings and errors to use the same style of: ``` error: some error message warning: some warning message ``` Additionally, warnings now only print out "warning" in yellow instead of the entire message (like errors do)
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
This was referenced Mar 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Cargo prints out errors justified like all other status messages, but
this can look odd without coloration:
Instead, this commit changes both warnings and errors to use the same style of:
Additionally, warnings now only print out "warning" in yellow instead of the
entire message (like errors do)