Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TOML parser to pick up a bugfix #2680

Merged
merged 1 commit into from
Jun 12, 2016

Conversation

alexcrichton
Copy link
Member

Cargo has previously accepted invalid TOML as valid, but this bugfix should fix
the problem. In order to prevent breaking all crates immediately toml-rs has a
compatibility mode which emulates the bug that was fixed. Cargo will issue a
warning if this compatibility is required to parse a crate.

@alexcrichton
Copy link
Member Author

r? @brson

@rust-highfive
Copy link

r? @wycats

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented May 15, 2016

☔ The latest upstream changes (presumably #2691) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented May 26, 2016

☔ The latest upstream changes (presumably #2743) made this pull request unmergeable. Please resolve the merge conflicts.

@brson
Copy link
Contributor

brson commented Jun 11, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jun 11, 2016

📌 Commit c17f9f0 has been approved by brson

@bors
Copy link
Contributor

bors commented Jun 11, 2016

⌛ Testing commit c17f9f0 with merge a00992f...

@bors
Copy link
Contributor

bors commented Jun 11, 2016

💔 Test failed - cargo-win-msvc-64

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jun 12, 2016

📌 Commit 0fa6f27 has been approved by brson

@bors
Copy link
Contributor

bors commented Jun 12, 2016

⌛ Testing commit 0fa6f27 with merge 0de788d...

@bors
Copy link
Contributor

bors commented Jun 12, 2016

💔 Test failed - cargo-mac-32

Cargo has previously accepted invalid TOML as valid, but this bugfix should fix
the problem. In order to prevent breaking all crates immediately toml-rs has a
compatibility mode which emulates the bug that was fixed. Cargo will issue a
warning if this compatibility is required to parse a crate.
@alexcrichton
Copy link
Member Author

@bors: r=brson

On Sun, Jun 12, 2016 at 1:02 PM, bors notifications@github.com wrote:

💔 Test failed - cargo-mac-32
http://buildbot.rust-lang.org/builders/cargo-mac-32/builds/1669


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2680 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95MktiRVfuFGduXHiuBzEU2-OwoBSks5qK-c-gaJpZM4IdXSK
.

@bors
Copy link
Contributor

bors commented Jun 12, 2016

📌 Commit 2a1e16c has been approved by brson

@bors
Copy link
Contributor

bors commented Jun 12, 2016

⌛ Testing commit 2a1e16c with merge f8e75ec...

bors added a commit that referenced this pull request Jun 12, 2016
Update TOML parser to pick up a bugfix

Cargo has previously accepted invalid TOML as valid, but this bugfix should fix
the problem. In order to prevent breaking all crates immediately toml-rs has a
compatibility mode which emulates the bug that was fixed. Cargo will issue a
warning if this compatibility is required to parse a crate.
@bors
Copy link
Contributor

bors commented Jun 12, 2016

@bors bors merged commit 2a1e16c into rust-lang:master Jun 12, 2016
@alexcrichton alexcrichton deleted the update-toml branch June 14, 2016 14:35
epage added a commit to epage/cargo that referenced this pull request Sep 21, 2021
- `set_require_newline_after_table` was added in rust-lang#2680 back in 2016
- `set_allow_duplicate_after_longer_table` was added in rust-lang#6761 in 2019

Several years later, this PR is turning these warnings into errors.

The function and documentation was kept so we can add additional hacks
in the future, like if we switch TOML parsers.
bors added a commit that referenced this pull request Sep 21, 2021
Remove TOML incompatibility hacks

- `set_require_newline_after_table` was added in #2680 back in 2016
- `set_allow_duplicate_after_longer_table` was added in #6761 in 2019

Several years later, this PR is turning these warnings into errors.

The function and documentation was kept so we can add additional hacks
in the future, like if we switch TOML parsers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants