Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore panic configuration for test/bench profiles #3175

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Ignore panic configuration for test/bench profiles #3175

merged 1 commit into from
Nov 3, 2016

Conversation

alexcrichton
Copy link
Member

Both of these profiles link to libtest, so it's invalid to configure them with
panic="abort". To prevent confusing errors just ignore the configuration for
now.

Closes #3166

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@AaronFriel AaronFriel mentioned this pull request Oct 11, 2016
Closed
@alexcrichton
Copy link
Member Author

ping r? @brson

@bors
Copy link
Contributor

bors commented Nov 2, 2016

☔ The latest upstream changes (presumably #3242) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Ignore panic configuration for test/bench profiles
0f44202 
Both of these profiles link to libtest, so it's invalid to configure them with
`panic="abort"`. To prevent confusing errors just ignore the configuration for
now.

Closes rust-lang#3166
@brson
Copy link
Contributor

brson commented Nov 3, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Nov 3, 2016

📌 Commit 0f44202 has been approved by brson

@bors
Copy link
Contributor

bors commented Nov 3, 2016

⌛ Testing commit 0f44202 with merge cb524b7...

bors added a commit that referenced this pull request Nov 3, 2016
@bors
Auto merge of #3175 - alexcrichton:bench-abort, r=brson
cb524b7 
Ignore `panic` configuration for test/bench profiles

Both of these profiles link to libtest, so it's invalid to configure them with
`panic="abort"`. To prevent confusing errors just ignore the configuration for
now.

Closes #3166
@bors
Copy link
Contributor

bors commented Nov 3, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: brson
Pushing cb524b7 to master...

@bors bors merged commit 0f44202 into rust-lang:master Nov 3, 2016
@bors bors mentioned this pull request Nov 3, 2016
Closed
@alexcrichton alexcrichton deleted the bench-abort branch November 3, 2016 17:49
@alecmocatta
Copy link

@alexcrichton In light of harness = false, does a blanket ignore of panic = "abort" for test/bench profiles still make sense?

I just tried this and was surprised to get `panic` setting is ignored for `test` profile, given that the integration test I wanted to run doesn't link to libtest.

@alexcrichton
Copy link
Member Author

@alecmocatta this PR is nearly two years old and is, uh, very far out of cache. Perhaps a new issue could be opened?

@ehuss ehuss added this to the 1.14.0 milestone Feb 6, 2022
@Imberflur Imberflur mentioned this pull request Oct 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Cannot run benchmarks with panic = "abort"
6 participants
@alexcrichton @rust-highfive @bors @brson @alecmocatta @ehuss