-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for targeted git dependencies #3275
Conversation
@alexcrichton can you verify that these tests should pass? |
I don't think that |
@alexcrichton the issue here is that the check for conflicts check for conflicting |
I've always felt pretty uneasy about multiple entries in the list of dependencies with the same name, if those are let through I suspect it will wreak havoc on the backend which wasn't expecting that at all. In that sense this likely won't be an easy bug to fix. Unfortunately I don't know the best way to tackle this right now :( |
I have an actual case for this where I'm trying to support both old libc as well as FreeBSD. The versions of libc required for the two cases are incompatible. Because I can't switch between two version of the same library, I've actually had to resort to cloning the respective crates and giving them a different name. |
☔ The latest upstream changes (presumably #4259) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm going to close this for now due to activity, but please feel free to resubmit of course! |
See #6212 |
See #3195