Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for targeted git dependencies #3275

Closed
wants to merge 2 commits into from

Conversation

wagenet
Copy link

@wagenet wagenet commented Nov 8, 2016

See #3195

@wagenet
Copy link
Author

wagenet commented Nov 8, 2016

@alexcrichton can you verify that these tests should pass?

@alexcrichton
Copy link
Member

I don't think that duplicate_deps_2 can probably pass, unfortunately, (but it'd be nice if it did!). The latter one would be nice to pass, yeah!

@wagenet
Copy link
Author

wagenet commented Nov 9, 2016

@alexcrichton the issue here is that the check for conflicts check for conflicting source_id (https://github.com/rust-lang/cargo/blob/master/src/cargo/util/toml.rs#L628). The dubplicate_deps_2 passes because all crates specified by version always have the same source_id, despite being different deps. When specified by path or git the source_ids vary and it's deemed a conflict. What do you think the correct approach to resolving this is?

@alexcrichton
Copy link
Member

I've always felt pretty uneasy about multiple entries in the list of dependencies with the same name, if those are let through I suspect it will wreak havoc on the backend which wasn't expecting that at all. In that sense this likely won't be an easy bug to fix. Unfortunately I don't know the best way to tackle this right now :(

@wagenet
Copy link
Author

wagenet commented Nov 14, 2016

I have an actual case for this where I'm trying to support both old libc as well as FreeBSD. The versions of libc required for the two cases are incompatible. Because I can't switch between two version of the same library, I've actually had to resort to cloning the respective crates and giving them a different name.

@bors
Copy link
Contributor

bors commented Jul 11, 2017

☔ The latest upstream changes (presumably #4259) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

I'm going to close this for now due to activity, but please feel free to resubmit of course!

@wagenet
Copy link
Author

wagenet commented Oct 23, 2018

See #6212

@wagenet wagenet deleted the targeted-git-dependencies branch October 23, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants